[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Clean up embedded scheme parsing/evaluation. (issue 577410045 by add
From: |
Benkő Pál |
Subject: |
Re: Clean up embedded scheme parsing/evaluation. (issue 577410045 by address@hidden) |
Date: |
Fri, 31 Jan 2020 12:04:00 +0100 |
<address@hidden> ezt írta (időpont: 2020. jan. 31., P, 11:55):
>
>
> https://codereview.appspot.com/577410045/diff/581560047/lily/parse-scm.cc
> File lily/parse-scm.cc (right):
>
> https://codereview.appspot.com/577410045/diff/581560047/lily/parse-scm.cc#newcode77
> lily/parse-scm.cc:77: const Input *hi = &ps->start_;
> On 2020/01/31 10:49:13, benko.pal wrote:
> > I understand (and like) adding the const, but can't understand
> changing the
> > reference to pointer even after reading the whole discussion.
>
> the change from & to * here is merely syntactical.
of course it is; but to me it's nearer to obfuscation than to cleanup.
- Re: Clean up embedded scheme parsing/evaluation. (issue 577410045 by address@hidden), (continued)
- Re: Clean up embedded scheme parsing/evaluation. (issue 577410045 by address@hidden), benko . pal, 2020/01/31
- Re: Clean up embedded scheme parsing/evaluation. (issue 577410045 by address@hidden), hanwenn, 2020/01/31
- Re: Clean up embedded scheme parsing/evaluation. (issue 577410045 by address@hidden),
Benkő Pál <=
- Re: Clean up embedded scheme parsing/evaluation. (issue 577410045 by address@hidden), nine . fierce . ballads, 2020/01/31
- Re: Clean up embedded scheme parsing/evaluation. (issue 577410045 by address@hidden), hanwenn, 2020/01/31
- Re: Clean up embedded scheme parsing/evaluation. (issue 577410045 by address@hidden), nine . fierce . ballads, 2020/01/31
- Re: Clean up embedded scheme parsing/evaluation. (issue 577410045 by address@hidden), hanwenn, 2020/01/31
- Re: Clean up embedded scheme parsing/evaluation. (issue 577410045 by address@hidden), Carl . D . Sorensen, 2020/01/31