Re: [PATCH] new patch for amd64

[Marco Gerards]

Ruslan Nikolaev <address@hidden> writes:

Hi Ruslan,

> I have seen another patch for amd64 by Marco Gerards. In fact month
> ago I sent the patch that also allows compiling on x86_64.

Right, I sent in this new patch because I don't like changing LD and
CC the way you do and because there were many special cases.  I had a
look how to change this and by the time I figured out a clean way, I
already had a new patch.  Hopefully you do not feel ignored (perhaps I
should've replied to your patch with this one as an alternative or
so...), that was not my intention.  You could say I was inspired to
fix AMD64 compilation this way because of your patch.

> By the way I decided to send new patch (it's really works with amd64).
>  
> Some bugs was fixed: - it doesn't break x86 compiling now (small bug)
> - it allows you to compile grub even you haven't libc32 and other
> 32-bit libraries and OS doesn't support executing 32-bit binaries. Of
> course -m32 gcc param is always available. But as you can see you also
> can't check regparm=3 bug in this case :( That is why for x86_64
> always using regparm=2 for nested functions in this patch.

Why can't you test for the regparam=3 bug?

> !!! PLEASE NOTE THAT IT'S NOT REAL NEED TO DO SPECIAL AMD64 VERSION
> BECAUSE USER CAN CHOOSE TO LOAD 32-bit operating system under
> x86_64. Moreover you can't switch to 64-bit by bootloader because you
> need enable paging first (that is not very clear to do by bootloader).

Right.  My patch is not 64 bits either.  What I would prefer is
applying my patch because it does not change that much and doesn't
require much special cases and it is a bit better readable (that's why
I sent it in basically).

After that I could have a look at your other patch.  But I prefer to
wait until Guillem sent in his patch for 64 bits ELF support.  If that
patch is applied we could change Ruslan's patch to use that code,
but if it takes too long Ruslan's patch can be applied first.

But I am not sure if we want a 64 bits multiboot and what is involved
with changing multiboot that way.  I leave that to Okuji.

Thanks,
Marco