Re: [patch] Widening terminal coordinates, and reading terminal size.

[Timothy Baldwin]

On Thursday 07 Oct 2004 10:22, Yoshinori K. Okuji wrote:

> I don't like getdimensions, since dimensions can be read as the number
> of axes. I vote for grub_getgeometry. Since GRUB does not have a window
> system, I don't think it is ambiguous.

I've changed it to grub_getgeometry. A new patch is attached, and here is the 
changelog:

2004-10-03  Timothy Baldwin  <address@hidden>

 * include/grub/term.h 
 (grub_getsizexy): New prototype.
 (grub_gotoxy): Arguments changed to unsigned.
 (grub_getxy): Returns via pointers to unsigned, instead of packed
 into a 16-bit value, all callers updated.
 (struct grub_term): Likewise for `grub_getxy'.  Added a new member
 `grub_getsizexy', arguments to `grub_gotoxy' changed to unsigned,
 `grub_getxy'.
 * kern/term.c (grub_getsizexy): New function.
 (grub_getxy): Changed arguments as above.
 * kern/i386/pc/startup.S (grub_console_getsizexy): New function.
 (grub_console_getxy): Changed arguments as above.
 * include/grub/i386/pc/console.h (grub_console_getsizexy): New prototype
 (grub_console_getxy): Changed arguments as above.
 * term/i386/pc/console.c (grub_console_term): Added grub_console_getsizexy.
 * term/powerpc/ieee1275/ofconsole.c (grub_ofconsole_getsizexy): New function.
 (grub_ofconsole_getxy): Changed arguments as above.
 (grub_ofconsole_term): Added grub_ofconsole_getsizexy.  
 * util/console.c (grub_ncurses_getsizexy): New function.
 (grub_ncurses_getxy): Changed arguments as above.
 (grub_ncurses_term): Added grub_ncurses_getsizexy.
 * term/i386/pc/console.c (grub_vga_getsizexy): New function.
 (grub_vga_getxy): Changed arguments as above.
 (grub_vga_term): Added grub_ncurses_getsizexy.
  
PS. I haven't signed any copyright forms. 

-- 
Member AFFS, WYLUG, SWP (UK), ANL, RESPECT, Leeds SA, Leeds Anti-war coalition
No to software patents!    No to DRM/EUCD - hands off our computers!

term.diff
Description: Text Data

pgpbxbqSv5OIa.pgp
Description: PGP signature