[patch] Dynamic Loader Bugs

[Timothy Baldwin]

1. Gcc 3.4 will delete the module initialization and finalisation functions as 
they appear to be unused.

2. grub_dl_load_file contains a null pointer dereference.

3. The modules contain common symbols, which the dynamic loader can't handle.

4. The dynamic loader uses the size of common symbols as their address, 
instead of returning an error.

Attached is a patch which fixes points 1 to 3.

2004-10-09  Timothy Baldwin  <address@hidden>

        * include/grub/dl.h (GRUB_MOD_INIT): Changed __attribute__ ((unused)) 
        to __attribute__ ((used)).
        (GRUB_MOD_FINI): Likewise.
        * kern/dl.c (grub_dl_load_file): Fix null pointer dereference.
        * genmk.rb (PModule): Assign space to common symbols when
          linking modules. 


-- 
Member AFFS, WYLUG, SWP (UK), ANL, RESPECT, Leeds SA, Leeds Anti-war coalition
No to software patents!    No to DRM/EUCD - hands off our computers!

dl.diff
Description: Text Data

pgpHN3waGYohg.pgp
Description: PGP signature