[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[task #16288] Warp: warn users when WCSLIB version is <7.12
From: |
Pedram Ashofteh-Ardakani |
Subject: |
[task #16288] Warp: warn users when WCSLIB version is <7.12 |
Date: |
Wed, 29 Mar 2023 07:02:39 -0400 (EDT) |
Follow-up Comment #4, task #16288 (project gnuastro):
Nicely done Labib! The message is clear and concise, and the variables and
checks are put in good places. Well done. You should go for the PR :) Mohammad
will also take a look at it before merging to master and setting this task as
complete.
I only have a question about
[https://github.com/labeeb-7z/GnuAstro/commit/91f41f0d6c6c77fac0d2e3664ae1cd9524dd1e86#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810R563-R565
lines 563-565]:
int ver[3]={-1,-1,-1};
wcslib_version(ver);
if(!(ver[0]>=7 && ver[1]>=12))exit(1);
Here, we're declaring `ver` of size 3. Does WCS follow the x.x.x versioning
pattern? Or is it just there to follow some kind of a standard that the
`wcslib_version` function is following?
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/task/?16288>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
- [task #16288] Warp: warn users when WCSLIB version is <7.12, Labib Asari, 2023/03/27
- Message not available
- [task #16288] Warp: warn users when WCSLIB version is <7.12, Pedram Ashofteh-Ardakani, 2023/03/27
- [task #16288] Warp: warn users when WCSLIB version is <7.12, Labib Asari, 2023/03/28
- Message not available
- [task #16288] Warp: warn users when WCSLIB version is <7.12,
Pedram Ashofteh-Ardakani <=
- [task #16288] Warp: warn users when WCSLIB version is <7.12, Pedram Ashofteh-Ardakani, 2023/03/29
- [task #16288] Warp: warn users when WCSLIB version is <7.12, Pedram Ashofteh-Ardakani, 2023/03/29
- [task #16288] Warp: warn users when WCSLIB version is <7.12, Labib Asari, 2023/03/29
- Message not available
- [task #16288] Warp: warn users when WCSLIB version is <7.12, Pedram Ashofteh-Ardakani, 2023/03/29