[task #15567] Converting hh:mm:ss and dd:mm:ss notations to degrees and vice vesa

[Mohammad Akhlaghi]

Follow-up Comment #13, task #15567 (project gnuastro):

Sorry! I forgot to clarify another point: since the parsing function may fail
to parse the string, as you have done, it is often necessary to call it with
an `if' statement. Its value is also not returned, but written into the
argument array. 

You can thus use these two points for the benefit of the readability of your
code! Notice how in my implementation it just returns an integer. The returned
value is 1 if it succeeds and 0 if it fails. So you can call it simply like
this:


if(gal_units_extract_decimal(convert, val))
 ....
else
 ....


The statement you had used (below) is very confusing: its returning the
opposite of true (0) to be true!


if (gal_units_extract_decimal (convert, val) == 0)


I hope this helps in writing a good code ;-).

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/task/?15567>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/