Re: [Gnash-dev] Logging code

[strk]

On Mon, Aug 07, 2006 at 01:42:00PM -0600, Rob Savoye wrote:
> strk wrote:
> > I think wrapping into IF_VERBOSE_WHAT() macro can be a good
> > first step, then we'll switch to C++ style calls.
> > Before proceeding it's worth cleanly define these macros.
> 
>   Yep. This is a good case for thinking out the best solution.
> 
> > For log_msg, log_action and log_processing we might reintroduce
> > in order: IF_VERBOSE, IF_VERBOSE_ACTION, IF_VERBOSE_PARSE.
> 
>   You mean something like this ?
> 
>   IF_VERBOSE(log_warning("ARG! it failed!: %s", sterrror(errno)));
>       or
>   IF_VERBOSE(dbglogfile << ARG! it failed!: " << terrror(errno) << endl;)

For log_warning and log_error I wouldn't allow compile-time disabling.
For log_msg, log_parse and log_action I'd just wrap inside IF_VERBOSE,
IF_VERBOSE_PARSE and IF_VERBOSE_ACTION. It doesn't matter what's inside
the macro (C or C++ version of call).

I just committed this change for log_parse calls.

--strk;

> 
> Since log_msg, et al. all use the same underlying infrastructure as
> dbglogfile, we should be able to mix C and C++ style debug logging. I
> don't think we need to mandate it one way or another.
> 
> > What do you think ?
> 
>   It's hard to think when you've been staring at hex dumps of RTMP and
> AMF network dumps for days... :-)
> 
>       - rob -
> 
> 
> _______________________________________________
> Gnash-dev mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/gnash-dev

-- 

 /"\    ASCII Ribbon Campaign
 \ /    Respect for low technology.
  X     Keep e-mail messages readable by any computer system.
 / \    Keep it ASCII.