[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: emacs-30 1fd7957bc72: ; cperl-mode.el: Add a test for Bug#74245
From: |
Michael Albinus |
Subject: |
Re: emacs-30 1fd7957bc72: ; cperl-mode.el: Add a test for Bug#74245 |
Date: |
Tue, 14 Jan 2025 16:13:03 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Peter Oliver <p.d.oliver@mavit.org.uk> writes:
Hi Peter,
>> Although both approaches should work, I'm in favor of Haralds
>> skip-unless, which gives a clear reason (missing precodition). The
>> :expected-result clause is rather meant for tests which do not run ATM,
>> and which are waiting for a fix.
>
> When I say “the bug is still present in perl-mode”, I mean bug 74245,
> reported against cperl-mode, and fixed in cperl-mode in commit b74ac4af940,
> is also present in perl-mode (in Emacs 30.0.93, at least).
Understood.
> I assume no-one has plans to fix it in perl-mode, however.
Don't know. But in this case, I still believe skip-unless is the better
choice (plus a comment that it won't be fixed in perl-mode).