[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: emacs-30 1fd7957bc72: ; cperl-mode.el: Add a test for Bug#74245
From: |
Michael Albinus |
Subject: |
Re: emacs-30 1fd7957bc72: ; cperl-mode.el: Add a test for Bug#74245 |
Date: |
Tue, 14 Jan 2025 14:50:45 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Peter Oliver <p.d.oliver@mavit.org.uk> writes:
Hi Peter,
>> Ouch, thanks. The test is not supposed to be run with perl-mode.
>> I failed to check that. Fixed!
In my environment, the fix works.
> Since the bug is still present in perl-mode, is the following better?
>
> :expected-result (if (eq cperl-test-mode #'perl-mode) :failed :passed)
Hmm. Perhaps you find the reason why it doesn't work for you?
Although both approaches should work, I'm in favor of Haralds
skip-unless, which gives a clear reason (missing precodition). The
:expected-result clause is rather meant for tests which do not run ATM,
and which are waiting for a fix.
Best regards. Michael.