Re: emacs-30 1fd7957bc72: ; cperl-mode.el: Add a test for Bug#74245

[Michael Albinus]

Harald Jörg <haj@posteo.de> writes:

Hi Harald,

>     * test/lisp/progmodes/cperl-mode-resources/cperl-bug-74245.pl: New test 
> data.
>     
>     * test/lisp/progmodes/cperl-mode-tests.el (cperl-test-bug-74245): Verify
>     that a bare \"$\" can appear at the end of a subroutine signature.

This breaks perl-mode-tests:

--8<---------------cut here---------------start------------->8---
# make -C test perl-mode-tests
Test cperl-test-bug-74245 backtrace:
  signal(ert-test-failed (((should (equal got expected)) :form (equal 
  ert-fail(((should (equal got expected)) :form (equal #("test case si
  (if (unwind-protect (setq value-1000 (apply fn-998 args-999)) (setq 
  (let (form-description-1002) (if (unwind-protect (setq value-1000 (a
  (let ((value-1000 'ert-form-evaluation-aborted-1001)) (let (form-des
  (let* ((fn-998 #'equal) (args-999 (condition-case err (list got expe
  (progn (insert code) (goto-char (point-min)) (funcall cperl-test-mod
  (unwind-protect (progn (insert code) (goto-char (point-min)) (funcal
  (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn
  (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current
  (let ((name (match-string 1)) (code (match-string 2)) (expected (mat
  (while (re-search-forward (concat "^# ?-+ \\_<\\(?1:.+?\\)\\_>: inpu
  (progn (insert-file-contents (expand-file-name "cperl-bug-74245.pl" 
  (unwind-protect (progn (insert-file-contents (expand-file-name "cper
  (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn
  (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current
  #f(lambda () [t] (let ((temp-buffer (generate-new-buffer " *temp*" t
  #f(compiled-function () #<bytecode 0x1a6253a16062f95>)()
  handler-bind-1(#f(compiled-function () #<bytecode 0x1a6253a16062f95>
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name cperl-test-bug-74245 :documentation "
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
  ert-run-tests-batch((not (tag :unstable)))
  ert-run-tests-batch-and-exit((not (tag :unstable)))
  eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t)
  command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
  command-line()
  normal-top-level()
Test cperl-test-bug-74245 condition:
    (ert-test-failed
     ((should (equal got expected)) :form
      (equal
       #("test case signature where last parameter is ignored:\npackage P {\n  
use v5.36;\n  sub ignore ($first, $) {}\n\11      ignore(qw(first 
second));\n\11    }\n"
         92 93 (syntax-table ...) 100 101 (syntax-table ...) 122 123
         (syntax-table ...) 135 136 (syntax-table ...))
       "test case signature where last parameter is ignored:\npackage P {\n  
use v5.36;\n  sub ignore ($first, $) {}\n  ignore(qw(first second));\n}\n")
      :value nil :explanation
      (arrays-of-different-length 146 136
                                  #("test case signature where last parameter 
is ignored:\npackage P {\n  use v5.36;\n  sub ignore ($first, $) {}\n\11      
ignore(qw(first second));\n\11    }\n"
                                    92 93 (syntax-table ...) 100 101
                                    (syntax-table ...) 122 123
                                    (syntax-table ...) 135 136
                                    (syntax-table ...))
                                  "test case signature where last parameter is 
ignored:\npackage P {\n  use v5.36;\n  sub ignore ($first, $) {}\n  
ignore(qw(first second));\n}\n"
                                  first-mismatch-at 106)))
   FAILED  28/67  cperl-test-bug-74245 (0.004184 sec) at 
lisp/progmodes/cperl-mode-tests.el:1592
--8<---------------cut here---------------end--------------->8---

Note, that cperl-mode-tests succeed.

Best regards, Michael.