emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: emacs-30 1fd7957bc72: ; cperl-mode.el: Add a test for Bug#74245


From: Peter Oliver
Subject: Re: emacs-30 1fd7957bc72: ; cperl-mode.el: Add a test for Bug#74245
Date: Tue, 14 Jan 2025 15:07:25 +0000 (GMT)

On Tue, 14 Jan 2025, Michael Albinus wrote:

Peter Oliver <p.d.oliver@mavit.org.uk> writes:

Ouch, thanks.  The test is not supposed to be run with perl-mode.
I failed to check that.  Fixed!

In my environment, the fix works.

Since the bug is still present in perl-mode, is the following better?

  :expected-result (if (eq cperl-test-mode #'perl-mode) :failed :passed)

Hmm. Perhaps you find the reason why it doesn't work for you?

Although both approaches should work, I'm in favor of Haralds
skip-unless, which gives a clear reason (missing precodition). The
:expected-result clause is rather meant for tests which do not run ATM,
and which are waiting for a fix.

When I say “the bug is still present in perl-mode”, I mean bug 74245, reported 
against cperl-mode, and fixed in cperl-mode in commit b74ac4af940, is also 
present in perl-mode (in Emacs 30.0.93, at least).

I assume no-one has plans to fix it in perl-mode, however.

--
Peter Oliver

reply via email to

[Prev in Thread] Current Thread [Next in Thread]