Re: eglot-test-diagnostic-tags-unnecessary-code fails with certain clangd versions

[Robert Pluim]

>>>>> On Wed, 22 Mar 2023 09:45:26 +0000, João Távora <joaotavora@gmail.com> 
>>>>> said:

    João> What I meant rather, was trying to install version 14 from one of
    João> those sources I listed earlier.  Perhaps all that we'll see is that
    João> instead of:

    João>   clangd-13 libclang-common-13-dev libclang-cpp13 libllvm13

    João> we'll see

    João>   clangd-14 libclang-common-14-dev libclang-cpp14 libllvm14

    João> If the former is acceptable so should be the latter, especially
    João> if the installation of the support libraries is motivated by
    João> clangd alone.

Maybe. Itʼs not on my list of things to try :-)

    João> Anyway, I now pushed a version-checking patch to master.
    >> 
    >> Thanks, that test is skipped for me now (aside: is there any way to
    >> get ert to not spew the diagnostic output from commands such as clangd
    >> to the terminal?)

    João> As far as I understand the output you mean, when running `make check`
    João> all this output goes to a separate file.  The output is very useful 
for
    João> debugging test failures.  But maybe I'm not following: what command
    João> are you running exactly?

The results go to a log file, but some of it also ends up on the
terminal (this is not specific to eglot, it happens with other tests
as well):

$ make -C test eglot-tests
make: Entering directory '/home/rpluim/repos/emacs/test'
make[1]: Entering directory '/home/rpluim/repos/emacs/test'
  GEN      lisp/progmodes/eglot-tests.log
Running 50 tests (2023-03-22 11:15:47+0100, selector `(not (or (tag :unstable) 
(tag :nativecomp)))')
[eglot-tests] [eglot-test-auto-detect-running-server]: test start
[eglot] Connected! Server `clangd' now managing `(c-mode c-ts-mode c++-mode 
c++-ts-mode)' buffers in project `project'.
[eglot-tests] [eglot-test-auto-detect-running-server]: OK
[eglot] Asking EGLOT (project/(c-mode c-ts-mode c++-mode c++-ts-mode)) politely 
to terminate
[jsonrpc] Server exited with status 9
[eglot-tests] Killing (cena.c coiso.c merdix.c), wiping 
/tmp/eglot--fixtureSVO44D, restoring nil
   passed   1/50  eglot-test-auto-detect-running-server (0.161681 sec)
[eglot-tests] [eglot-test-auto-reconnect]: test start
[eglot] Connected! Server `clangd' now managing `(c-mode c-ts-mode c++-mode 
c++-ts-mode)' buffers in project `project'.
[jsonrpc] Server exited with status 9
[eglot] (warning) Reconnecting after unexpected server exit.
Warning (eglot): Reconnecting after unexpected server exit.
[eglot] Connected! Server `clangd' now managing `(c-mode c-ts-mode c++-mode 
c++-ts-mode)' buffers in project `project'.
[eglot] Reconnected!
[jsonrpc] Server exited with status 9
[eglot] (warning) Not auto-reconnecting, last one didn't last long.
Warning (eglot): Not auto-reconnecting, last one didn't last long.
[eglot-tests] [eglot-test-auto-reconnect]: OK
[eglot-tests] Killing (thingy.c), wiping /tmp/eglot--fixture0bo9S2, restoring 
nil
   passed   2/50  eglot-test-auto-reconnect (2.342542 sec)
[eglot-tests] [eglot-test-auto-shutdown]: test start
[eglot] Connected! Server `clangd' now managing `(c-mode c-ts-mode c++-mode 
c++-ts-mode)' buffers in project `project'.
[eglot] Asking EGLOT (project/(c-mode c-ts-mode c++-mode c++-ts-mode)) politely 
to terminate
[jsonrpc] Server exited with status 9
[eglot-tests] [eglot-test-auto-shutdown]: OK
[eglot-tests] Killing nil, wiping /tmp/eglot--fixtureFDN5l3, restoring nil
   passed   3/50  eglot-test-auto-shutdown (0.162224 sec)
  skipped   4/50  eglot-test-basic-completions (0.000283 sec)
[eglot-tests] [eglot-test-basic-diagnostics]: test start
[eglot] Connected! Server `clangd' now managing `(c-mode c-ts-mode c++-mode 
c++-ts-mode)' buffers in project `diag-project'.
[eglot-tests] waiting for `(string= method textDocument/publishDiagnostics)'
.
[eglot-tests] detected: textDocument/publishDiagnostics

[eglot-tests] [eglot-test-basic-diagnostics]: OK
[eglot] Asking EGLOT (diag-project/(c-mode c-ts-mode c++-mode c++-ts-mode)) 
politely to terminate
[jsonrpc] Server exited with status 9
[eglot-tests] Killing (main.c), wiping /tmp/eglot--fixtureA3MDfA, restoring nil
   passed   5/50  eglot-test-basic-diagnostics (0.339335 sec)
  skipped   6/50  eglot-test-basic-xref (0.001034 sec)
   passed   7/50  eglot-test-capabilities (0.000371 sec)
   passed   8/50  eglot-test-dcase (0.000354 sec)
   passed   9/50  eglot-test-dcase-issue-452 (0.000252 sec)
  skipped  10/50  eglot-test-diagnostic-tags-unnecessary-code (0.023891 sec)
  skipped  11/50  eglot-test-eclipse-connect (0.000277 sec)
  skipped  12/50  eglot-test-eldoc-after-completions (0.000297 sec)
[eglot-tests] [eglot-test-ensure]: test start
[eglot] Connected! Server `clangd' now managing `(c-mode c-ts-mode c++-mode 
c++-ts-mode)' buffers in project `project'.
[eglot-tests] [eglot-test-ensure]: OK
[eglot] Asking EGLOT (project/(c-mode c-ts-mode c++-mode c++-ts-mode)) politely 
to terminate
[jsonrpc] Server exited with status 9
[eglot-tests] Killing (foo.c bar.c), wiping /tmp/eglot--fixtureUZO630, 
restoring (c-mode-hook)
   passed  13/50  eglot-test-ensure (0.242147 sec)
   passed  14/50  eglot-test-glob-test (0.084042 sec)
  skipped  15/50  eglot-test-javascript-basic (0.000492 sec)
  skipped  16/50  eglot-test-json-basic (0.000390 sec)
[eglot-tests] [eglot-test-lsp-abiding-column]: test start
[eglot] Connected! Server `clangd' now managing `(c-mode)' buffers in project 
`project'.
[eglot-tests] waiting for `(should (equal 71 (cadddr (cadadr (aref (cadddr 
params) 0)))))'
[eglot-tests] detected: textDocument/didChange
[eglot-tests] [eglot-test-lsp-abiding-column]: OK
[eglot] Asking EGLOT (project/(c-mode)) politely to terminate
[jsonrpc] Server exited with status 9
[eglot-tests] Killing (foo.c), wiping /tmp/eglot--fixturejFxISB, restoring nil
   passed  17/50  eglot-test-lsp-abiding-column (0.181948 sec)
  skipped  18/50  eglot-test-multiline-eldoc (0.000361 sec)
  skipped  19/50  eglot-test-non-unique-completions (0.000314 sec)
  skipped  20/50  eglot-test-path-to-uri-windows (0.000125 sec)
  skipped  21/50  eglot-test-project-wide-diagnostics-rust-analyzer (0.000276 
sec)
  skipped  22/50  eglot-test-project-wide-diagnostics-typescript (0.000297 sec)
  skipped  23/50  eglot-test-python-autopep-formatting (0.000262 sec)
  skipped  24/50  eglot-test-python-yapf-formatting (0.000260 sec)
[eglot-tests] [eglot-test-rename-a-symbol]: test start
[eglot] Connected! Server `clangd' now managing `(c-mode c-ts-mode c++-mode 
c++-ts-mode)' buffers in project `rename-project'.
[eglot] applying 2 edits to `main.c'... 
[eglot] applying 2 edits to `main.c'...done
[eglot] Edit successful!
[eglot-tests] [eglot-test-rename-a-symbol]: OK
[eglot] Asking EGLOT (rename-project/(c-mode c-ts-mode c++-mode c++-ts-mode)) 
politely to terminate
[jsonrpc] Server exited with status 9
[eglot-tests] Killing (main.c), wiping /tmp/eglot--fixtureVbF4jY, restoring nil
   passed  25/50  eglot-test-rename-a-symbol (0.153973 sec)
  skipped  26/50  eglot-test-rust-analyzer-hover-after-edit (0.000611 sec)
  skipped  27/50  eglot-test-rust-analyzer-watches-files (0.000545 sec)
  skipped  28/50  eglot-test-rust-on-type-formatting (0.000578 sec)
[eglot-tests] [eglot-test-same-server-multi-mode]: test start
[eglot] Connected! Server `clangd' now managing `(c++-mode c-mode c-ts-mode 
c++-ts-mode)' buffers in project `project'.
[eglot-tests] [eglot-test-same-server-multi-mode]: OK
[eglot] Asking EGLOT (project/(c++-mode c-mode c-ts-mode c++-ts-mode)) politely 
to terminate
[jsonrpc] Server exited with status 9
[eglot-tests] Killing (foo.cpp foolib.h foolib.c), wiping 
/tmp/eglot--fixture1WKNsB, restoring nil
   passed  29/50  eglot-test-same-server-multi-mode (0.156214 sec)
   passed  30/50  eglot-test-server-programs-class-name-and-contact-spec 
(0.001711 sec)
   passed  31/50  eglot-test-server-programs-class-name-and-plist (0.000274 sec)
   passed  32/50  eglot-test-server-programs-executable-multiple-major-modes 
(0.000292 sec)
   passed  33/50  eglot-test-server-programs-executable-with-arg (0.000279 sec)
   passed  34/50  eglot-test-server-programs-executable-with-args-and-autoport 
(0.000266 sec)
   passed  35/50  eglot-test-server-programs-function (0.000302 sec)
   passed  36/50  eglot-test-server-programs-guess-lang (0.000503 sec)
   passed  37/50  eglot-test-server-programs-host-and-port (0.000304 sec)
   passed  38/50  eglot-test-server-programs-host-and-port-and-tcp-args 
(0.000265 sec)
   passed  39/50  eglot-test-server-programs-simple-executable (0.000274 sec)
   passed  40/50  eglot-test-server-programs-simple-missing-executable 
(0.000285 sec)
  skipped  41/50  eglot-test-single-line-eldoc (0.000343 sec)
[eglot-tests] [eglot-test-slow-async-connection]: test start
[eglot] Waiting in background for server `EGLOT (project/(c-mode))'
[eglot] Connected! Server `clangd' now managing `(c-mode)' buffers in project 
`project'.
[eglot-tests] [eglot-test-slow-async-connection]: OK
[eglot] Asking EGLOT (project/(c-mode)) politely to terminate
[jsonrpc] Server exited with status 9
[eglot-tests] Killing (something.c), wiping /tmp/eglot--fixtureGOw9Qx, 
restoring nil
   passed  42/50  eglot-test-slow-async-connection (2.219000 sec)
[eglot-tests] [eglot-test-slow-sync-connection-intime]: test start
[eglot] Connected! Server `clangd' now managing `(c-mode)' buffers in project 
`project'.
[eglot-tests] [eglot-test-slow-sync-connection-intime]: OK
[eglot] Asking EGLOT (project/(c-mode)) politely to terminate
[jsonrpc] Server exited with status 9
[eglot-tests] Killing (something.c), wiping /tmp/eglot--fixturedlRt53, 
restoring nil
   passed  43/50  eglot-test-slow-sync-connection-intime (1.154543 sec)
[eglot-tests] [eglot-test-slow-sync-connection-wait]: test start
[eglot] Connected! Server `clangd' now managing `(c-mode)' buffers in project 
`project'.
[eglot-tests] [eglot-test-slow-sync-connection-wait]: OK
[eglot] Asking EGLOT (project/(c-mode)) politely to terminate
[jsonrpc] Server exited with status 9
[eglot-tests] Killing (something.c), wiping /tmp/eglot--fixtureH37RjM, 
restoring nil
   passed  44/50  eglot-test-slow-sync-connection-wait (1.160179 sec)
[eglot-tests] [eglot-test-slow-sync-timeout]: test start
[jsonrpc] Server exited with status 9
[eglot-tests] [eglot-test-slow-sync-timeout]: OK
[eglot-tests] Killing (something.c), wiping /tmp/eglot--fixturecLAgnU, 
restoring nil
   passed  45/50  eglot-test-slow-sync-timeout (1.131108 sec)
  skipped  46/50  eglot-test-snippet-completions (0.000943 sec)
  skipped  47/50  eglot-test-snippet-completions-with-company (0.000599 sec)
   passed  48/50  eglot-test-strict-interfaces (0.000569 sec)
[eglot-tests] [eglot-test-tramp-test]: test start


[eglot] Connected! Server `clangd' now managing `(c-mode c-ts-mode c++-mode 
c++-ts-mode)' buffers in project `project'.




[eglot-tests] [eglot-test-tramp-test]: OK
[eglot] Asking EGLOT (project/(c-mode c-ts-mode c++-mode c++-ts-mode)) politely 
to terminate
[jsonrpc] Server exited with status 9
[eglot-tests] Killing (cena.c coiso.c merdix.c), wiping 
/mock:rltb:/tmp/eglot--fixturezOSKmQ, restoring nil
   passed  49/50  eglot-test-tramp-test (0.632109 sec)
[eglot-tests] [eglot-test-tramp-test-2]: test start


[eglot] Connected! Server `clangd' now managing `(c-mode)' buffers in project 
`project'.
[eglot-tests] waiting for `(should (equal 71 (cadddr (cadadr (aref (cadddr 
params) 0)))))'
[eglot-tests] detected: textDocument/didChange
[eglot-tests] [eglot-test-tramp-test-2]: OK
[eglot] Asking EGLOT (project/(c-mode)) politely to terminate
[jsonrpc] Server exited with status 9
[eglot-tests] Killing (foo.c), wiping /mock:rltb:/tmp/eglot--fixture8XZVqO, 
restoring nil
File is missing: /mock:rltb:/tmp/eglot--fixture8XZVqO/project/foo.c~
   passed  50/50  eglot-test-tramp-test-2 (0.412540 sec)

Ran 50 tests, 30 results as expected, 0 unexpected, 20 skipped (2023-03-22 
11:15:57+0100, 10.577235 sec)

20 skipped results:
  SKIPPED  eglot-test-basic-completions
  SKIPPED  eglot-test-basic-xref
  SKIPPED  eglot-test-diagnostic-tags-unnecessary-code
  SKIPPED  eglot-test-eclipse-connect
  SKIPPED  eglot-test-eldoc-after-completions
  SKIPPED  eglot-test-javascript-basic
  SKIPPED  eglot-test-json-basic
  SKIPPED  eglot-test-multiline-eldoc
  SKIPPED  eglot-test-non-unique-completions
  SKIPPED  eglot-test-path-to-uri-windows
  SKIPPED  eglot-test-project-wide-diagnostics-rust-analyzer
  SKIPPED  eglot-test-project-wide-diagnostics-typescript
  SKIPPED  eglot-test-python-autopep-formatting
  SKIPPED  eglot-test-python-yapf-formatting
  SKIPPED  eglot-test-rust-analyzer-hover-after-edit
  SKIPPED  eglot-test-rust-analyzer-watches-files
  SKIPPED  eglot-test-rust-on-type-formatting
  SKIPPED  eglot-test-single-line-eldoc
  SKIPPED  eglot-test-snippet-completions
  SKIPPED  eglot-test-snippet-completions-with-company

make[1]: Leaving directory '/home/rpluim/repos/emacs/test'
make: Leaving directory '/home/rpluim/repos/emacs/test'

Robert
--