Re: "Can't find Hunspell dictionary" error (was Re: Emacs pretest 28.0.91 is out)

[Eli Zaretskii]

> Date: Fri, 14 Jan 2022 14:05:56 +1300
> From: Phil Sainty <psainty@orcon.net.nz>
> Cc: Robert Pluim <rpluim@gmail.com>, stefan@marxist.se, emacs-devel@gnu.org
> 
> On 2022-01-14 03:42, Eli Zaretskii wrote:
> >>     >> Using `with-demoted-errors' would achieve both goals, I think?
> >> 
> >>     Eli> Using that where? in the test suite?
> >> 
> >> Yes, for this one specific test. Although Iʼd prefer `ignore-errors',
> > 
> > Fine with me.
> 
> I agree with `ignore-errors' for the test suite.
> 
> My `with-⁠demoted-⁠errors' suggestion was actually regarding
> `ispell-⁠valid-⁠dictionary-⁠list' or `ispell-⁠set-⁠spellchecker-⁠params'
> as I wouldn't expect an absence of dictionaries to cause those
> functions (or at least the former) to fail.
> 
> I haven't looked at them in detail, but my gut feeling was that
> `ispell-⁠valid-⁠dictionary-⁠list' should be returning an empty list
> in that scenario.  I thought that if a warning message was logged
> along the way to point out that no dictionaries were installed,
> that would seem fine (and preferable to an error).
> 
> Maybe not a change for 28.1, but potentially for master?

It is not clear to me what change you have in mind, or what change
could at all be possible.

We signal an error there because without it we will signal an error
later, where the context is lost and we cannot provide a meaningful
error message.

So with the current code, signaling an error there was deemed to be
the best solution for a situation where a spell-checker cannot do
anything useful -- without dictionaries, the speller is useless.  How
would you propose to continue using a speller without dictionaries,
and how would it help to return an empty list of dictionaries to the
caller? what would the caller do with such an empty list?

IOW, when you say "I wouldn't expect an absence of dictionaries to
cause those functions to fail", what do you expect from spell-checking
commands to do instead, when there are no dictionaries available to
them, except fail?