Re: project.el: git submodules?

[Kévin Le Gouguec]

Dmitry Gutov <address@hidden> writes:

> On 15.05.2020 04:21, Dmitry Gutov wrote:
>> OK.
>> Here's a patch you can try:
>> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
>> index ac56537b97..bc79e7591b 100644
>> --- a/lisp/progmodes/project.el
>
> I've just pushed an improved version of this patch to master.
>
> And now that project.el is in ELPA, it should be updated soon as well
> (look for version 0.1.1).

I've tried commit 779bc886:

✓ within "nested" projects (e.g. when $HOME is under version control,
  and visiting the Emacs repo under ~/src/emacs), project-find-file uses
  the innermost project (~/src/emacs) as root,

✓ at the root of a Git worktree (e.g. when ~/src/emacs-26.3 is a
  worktree of ~/src/emacs, and visiting ~/src/emacs-26.3),
  project-find-file uses the worktree (~/src/emacs-26.3) as root,

    ❌ in a subfolder of a Git worktree (e.g. in ~/src/emacs-26.3/src),
      project-find-file signals:

> project-try-vc: Opening input file: No such file or directory, 
> /home/$USER/src/emacs-26.3/src/.git

✓ at the root of a Git submodule (e.g. when ~/projects/foo/bar is a
  submodule of ~/projects/foo, and visiting ~/projects/foo/bar),
  project-find-file uses the parent module (~/projects/foo) as root,

    ❌ in a subfolder of a Git submodule (e.g. in
      ~/projects/foo/bar/baz), project-find-file signals:

> project-try-vc: Opening input file: No such file or directory, 
> /home/$USER/projects/foo/bar/baz/.git


I hope I got that right.  Thank you for working on this; I'd love for
project-find-file to finally work in worktrees :)