Re: Fill column indicator functionality

[Ergus]

Here is a patch with Eli's fixes and corrections:

Actually I have 3 more questions:

1) In the graphical mode the character I use now (?\u2502) does not look
like a vertical line (there is a small vertical space between them so
the line now looks like with ?|); in terminal it looks fine. What's the
proper way to change the font size or the character itself to fit the
entire row height in the graphical mode?

2) Are there any extra considerations needed to use the character
?\u2502 ? Is it needed to check (for example) if the actual fonts can
display it properly?

3) Actually there are 3 possible configuration options the column
number, the character, and the font. Should we provide some other
alternative?

The next step is to implement the R2L version of this, but I don't have
used R2L editing ever, so it may take a while.

On Wed, Mar 13, 2019 at 10:09:42PM +0200, Eli Zaretskii wrote:
> > Date: Wed, 13 Mar 2019 21:02:25 +0100
> > From: Ergus <address@hidden>
> > Cc: address@hidden
> >
> > >  Lisp_Object save_object = it->object;
> > >  it->object = Qnil;
> > >
> > >before the call to PRODUCE_GLYPHS, and then restore it->object to its
> > >previous value after PRODUCE_GLYPHS.
> > >
> > I thought that append_stretch_glyph was putting the it->object to Now I
> > see it didn't.
>
> append_stretch_glyph only does that for the stretch glyph it creates,
> it doesn't change it->object.
>
> > 1E6 Thanks.
>
> My pleasure.

display-fill-column-indicator_wip.patch
Description: Text document