Re: [PATCH] Use O_BINARY to detect whether to pass "rb" to popen

bug-gnu-utils

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Use O_BINARY to detect whether to pass "rb" to popen

From:	Paul Eggert
Subject:	Re: [PATCH] Use O_BINARY to detect whether to pass "rb" to popen
Date:	Thu, 21 May 2015 09:51:42 -0700
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

On 05/21/2015 09:36 AM, Filipe Brandenburger wrote:

Any suggestions of what's the best way to solve this?


I suggest doing what Emacs does.  Put this in a header somewhere:

#if O_BINARY
# define FOPEN_BINARY "b"
# define FOPEN_TEXT "t"
#else
# define FOPEN_BINARY ""
# define FOPEN_TEXT ""
#endif

and then call 'popen (cmd, "r" FOPEN_BINARY)'. Emacs does the samething with fopen of course. In practice this is good enough.

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH 0/4] Cross compiling sharutils, Bruce Korb, 2015/05/19
- Re: [PATCH 0/4] Cross compiling sharutils, Eric Blake, 2015/05/19
  - Re: [PATCH 0/4] Cross compiling sharutils, Eli Zaretskii, 2015/05/19
    - Re: [PATCH 0/4] Cross compiling sharutils, Bruce Korb, 2015/05/20
    - Re: [PATCH 0/4] Cross compiling sharutils, Eric Blake, 2015/05/21
    - Re: [PATCH 0/4] Cross compiling sharutils, Filipe Brandenburger, 2015/05/21
    - Re: [PATCH 0/4] Cross compiling sharutils, Filipe Brandenburger, 2015/05/21
    - [PATCH] Use O_BINARY to detect whether to pass "rb" to popen, Filipe Brandenburger, 2015/05/21
    - Re: [PATCH] Use O_BINARY to detect whether to pass "rb" to popen, Eli Zaretskii, 2015/05/21
    - Re: [PATCH] Use O_BINARY to detect whether to pass "rb" to popen, Filipe Brandenburger, 2015/05/21
    - Re: [PATCH] Use O_BINARY to detect whether to pass "rb" to popen, Paul Eggert <=
    - Re: [PATCH] Use O_BINARY to detect whether to pass "rb" to popen, Filipe Brandenburger, 2015/05/21
    - Re: [PATCH] Use O_BINARY to detect whether to pass "rb" to popen, Eli Zaretskii, 2015/05/21
    - Re: [PATCH] Use O_BINARY to detect whether to pass "rb" to popen, Bruce Korb, 2015/05/21
    - Re: [PATCH] Use O_BINARY to detect whether to pass "rb" to popen, Filipe Brandenburger, 2015/05/22
    - Re: [PATCH] Use O_BINARY to detect whether to pass "rb" to popen, Eli Zaretskii, 2015/05/22
    - Re: [PATCH] Use O_BINARY to detect whether to pass "rb" to popen, Andreas Schwab, 2015/05/22
    - Re: [PATCH] Use O_BINARY to detect whether to pass "rb" to popen, Bruce Korb, 2015/05/22
    - Re: [PATCH] Use O_BINARY to detect whether to pass "rb" to popen, Filipe Brandenburger, 2015/05/22
    - [PATCH 1/2] Use O_BINARY to detect whether to pass "rb" to popen, Filipe Brandenburger, 2015/05/22
    - [PATCH 2/2] Be more careful in guarding against pathological "begin" lines, Filipe Brandenburger, 2015/05/22

Prev by Date: Re: [PATCH] Use O_BINARY to detect whether to pass "rb" to popen
Next by Date: Re: [PATCH] Use O_BINARY to detect whether to pass "rb" to popen
Previous by thread: Re: [PATCH] Use O_BINARY to detect whether to pass "rb" to popen
Next by thread: Re: [PATCH] Use O_BINARY to detect whether to pass "rb" to popen
Index(es):
- Date
- Thread