bug-gnu-utils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Use O_BINARY to detect whether to pass "rb" to popen


From: Bruce Korb
Subject: Re: [PATCH] Use O_BINARY to detect whether to pass "rb" to popen
Date: Fri, 22 May 2015 08:32:30 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0

On 05/22/15 02:15, Andreas Schwab wrote:
    {
-    FILE * in_fp = popen (cmdline, "r");
+    FILE * in_fp = popen (cmdline, "r" TEXT_MODE);

Didn't you mean FOPEN_TEXT?

Indeed, and yet it built and went through "make distcheck".
And, yes, the patch included a non-related issue.  Someone came up
with a tortured uu-encoded file that would cause uudecode to seg fault.
The patch was against the v4.15.1 tag.

Thank you all!

Regards, Bruce



reply via email to

[Prev in Thread] Current Thread [Next in Thread]