Re: [PATCH 0/4] Cross compiling sharutils

[Eric Blake]

On 05/19/2015 05:23 PM, Bruce Korb wrote:
> 
>> 2) Use a configure check to detect whether the host OS *requires*
>> binary mode
>>    for that particular popen call.  It seems the patch was introduced for
>>    cygwin, unfortunately I don't really have access to a cygwin
>> machine to
>>    check whether that makes a difference and to propose a check here. 
>> In the
>>    bug-gnulib@ thread, Eric proposed using O_BINARY to detect that,
>> perhaps
>>    that's a possibility?

You probably don't even need a configure check.  As in simply:

popen(..., O_BINARY ? "rb" : "r")

That is, the few platforms where O_BINARY is non-zero probably already
support "rb" as a mode for popen (are there any besides Cygwin and mingw?).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature