[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/4] Cross compiling sharutils
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH 0/4] Cross compiling sharutils |
|
Date: |
Wed, 20 May 2015 22:05:14 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 05/20/2015 09:51 PM, Bruce Korb wrote:
> On 05/19/15 19:56, Eli Zaretskii wrote:
>>> Date: Tue, 19 May 2015 19:57:25 -0600
>>> From: Eric Blake <address@hidden>
>>> Cc: bug-gnu-utils <address@hidden>
>>>
>>> That is, the few platforms where O_BINARY is non-zero probably already
>>> support "rb" as a mode for popen (are there any besides Cygwin and
>>> mingw?).
>>
>> DJGPP.
>
> That answers the question, "Does popen support "rb" as an open mode?"
> The other question is: "Is O_BINARY non-zero on DJGPP, too?" I would
> expect.
>
> Actually, since we're also dealing with glibc, which is perfect in every
> way
> and has no need of facilitating cross platform development, O_BINARY
> is not defined:
gnulib does:
#ifndef O_BINARY
#define O_BINARY 0
#endif
which is perfectly fine; you can then use 'if (O_BINARY)' throughout
your code to bracket code that is only needed on platforms where text is
different from binary.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [PATCH 0/4] Cross compiling sharutils, Bruce Korb, 2015/05/19
- Re: [PATCH 0/4] Cross compiling sharutils, Eric Blake, 2015/05/19
- Re: [PATCH 0/4] Cross compiling sharutils, Eli Zaretskii, 2015/05/19
- Re: [PATCH 0/4] Cross compiling sharutils, Bruce Korb, 2015/05/20
- Re: [PATCH 0/4] Cross compiling sharutils,
Eric Blake <=
- Re: [PATCH 0/4] Cross compiling sharutils, Filipe Brandenburger, 2015/05/21
- Re: [PATCH 0/4] Cross compiling sharutils, Filipe Brandenburger, 2015/05/21
- [PATCH] Use O_BINARY to detect whether to pass "rb" to popen, Filipe Brandenburger, 2015/05/21
- Re: [PATCH] Use O_BINARY to detect whether to pass "rb" to popen, Eli Zaretskii, 2015/05/21
- Re: [PATCH] Use O_BINARY to detect whether to pass "rb" to popen, Filipe Brandenburger, 2015/05/21
- Re: [PATCH] Use O_BINARY to detect whether to pass "rb" to popen, Paul Eggert, 2015/05/21
- Re: [PATCH] Use O_BINARY to detect whether to pass "rb" to popen, Filipe Brandenburger, 2015/05/21
- Re: [PATCH] Use O_BINARY to detect whether to pass "rb" to popen, Eli Zaretskii, 2015/05/21
- Re: [PATCH] Use O_BINARY to detect whether to pass "rb" to popen, Bruce Korb, 2015/05/21
- Re: [PATCH] Use O_BINARY to detect whether to pass "rb" to popen, Filipe Brandenburger, 2015/05/22