Re: [Cp-tools-discuss] gnu.bytecode

[Per Bothner]

Elliott Hughes wrote:
> i think what you checked in contains a bug:
>
>     short mask
>       = (kind == 'C' ? CLASS_MODIFIERS
>          : kind == 'F' ? FIELD_MODIFIERS
>          : kind == 'F' ? METHOD_MODIFIERS
>          : (CLASS_MODIFIERS|FIELD_MODIFIERS|METHOD_MODIFIERS));
>
> shouldn't the second 'F' be 'M'?

Yes, indeed.

> i'm also not sure i understand the Access.toString() method, and its  
> use in decoding the InnerClasses attribute; shouldn't that use  
> Access.toString(blah, 'C')?

Yes, that would be better.

I checked in both fixes.
--
        --Per Bothner
address@hidden   http://per.bothner.com/