bug#68559: [PATCH] Improve Python shell completion

[Liu Hui]

On Tue, Mar 12, 2024 at 12:02 AM Basil L. Contovounesios
<basil@contovou.net> wrote:
>
> Liu Hui [2024-03-11 19:35 +0800] wrote:
>
> > On Fri, Mar 8, 2024 at 11:44 PM Basil L. Contovounesios
> > <basil@contovou.net> wrote:
> >>
> >> Liu Hui [2024-03-06 18:14 +0800] wrote:
> >>
> >> > -                   (string-match-p "ipython[23]?\\'" 
> >> > python-shell-interpreter)))))
> >> > +                   (or (string-match-p "ipython[23]?\\'" 
> >> > python-shell-interpreter)
> >> > +                       (string= python-shell-readline-completer-delims 
> >> > ""))))))
> >>
> >> Just curious: what does the empty string signify?
> >>
> >> [ If it's not just a dumb question, perhaps the meaning could be added
> >>   to the variable's docstring/commentary. ]
> >
> > The empty string means no characters are considered delimiters and the
> > readline completion could consider the entire line of input without
> > breaking it into parts based on typical delimiters like spaces or
> > punctuation. The docstring is updated in the attached patch.
>
> Thanks!  But that makes me wonder: in the cases where we check
>
>   (string= python-shell-readline-completer-delims "")
>
> is there a possibility that the variable's value will be nil?
> (In which case we should compare with equal instead of string=.)

Yes, it is a string with native completion and may be nil with
non-native completion. I have updated the patch. Thanks.

0001-Detect-the-readline-support-for-Python-shell-complet.patch
Description: Text Data