[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#68559: [PATCH] Improve Python shell completion
From: |
Basil L. Contovounesios |
Subject: |
bug#68559: [PATCH] Improve Python shell completion |
Date: |
Fri, 08 Mar 2024 16:44:03 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Liu Hui [2024-03-06 18:14 +0800] wrote:
> I have updated the patch.
Thanks! The build and tests succeed here, without skipped tests.
> + (unless (string-match-p "No readline support" output)
Nit: why not plain 'string-search' instead of a regexp search?
> - (string-match-p "ipython[23]?\\'"
> python-shell-interpreter)))))
> + (or (string-match-p "ipython[23]?\\'"
> python-shell-interpreter)
> + (string= python-shell-readline-completer-delims
> ""))))))
Just curious: what does the empty string signify?
[ If it's not just a dumb question, perhaps the meaning could be added
to the variable's docstring/commentary. ]
--
Basil
- bug#68559: [PATCH] Improve Python shell completion, Liu Hui, 2024/03/06
- bug#68559: [PATCH] Improve Python shell completion,
Basil L. Contovounesios <=
- bug#68559: [PATCH] Improve Python shell completion, Liu Hui, 2024/03/11
- bug#68559: [PATCH] Improve Python shell completion, Basil L. Contovounesios, 2024/03/11
- bug#68559: [PATCH] Improve Python shell completion, Liu Hui, 2024/03/13
- bug#68559: [PATCH] Improve Python shell completion, Basil L. Contovounesios, 2024/03/14
- bug#68559: [PATCH] Improve Python shell completion, Liu Hui, 2024/03/16
- bug#68559: [PATCH] Improve Python shell completion, Eli Zaretskii, 2024/03/16