[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#68559: [PATCH] Improve Python shell completion
From: |
Basil L. Contovounesios |
Subject: |
bug#68559: [PATCH] Improve Python shell completion |
Date: |
Mon, 11 Mar 2024 17:02:48 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Liu Hui [2024-03-11 19:35 +0800] wrote:
> On Fri, Mar 8, 2024 at 11:44 PM Basil L. Contovounesios
> <basil@contovou.net> wrote:
>>
>> Liu Hui [2024-03-06 18:14 +0800] wrote:
>>
>> > - (string-match-p "ipython[23]?\\'"
>> > python-shell-interpreter)))))
>> > + (or (string-match-p "ipython[23]?\\'"
>> > python-shell-interpreter)
>> > + (string= python-shell-readline-completer-delims
>> > ""))))))
>>
>> Just curious: what does the empty string signify?
>>
>> [ If it's not just a dumb question, perhaps the meaning could be added
>> to the variable's docstring/commentary. ]
>
> The empty string means no characters are considered delimiters and the
> readline completion could consider the entire line of input without
> breaking it into parts based on typical delimiters like spaces or
> punctuation. The docstring is updated in the attached patch.
Thanks! But that makes me wonder: in the cases where we check
(string= python-shell-readline-completer-delims "")
is there a possibility that the variable's value will be nil?
(In which case we should compare with equal instead of string=.)
--
Basil