bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#68559: [PATCH] Improve Python shell completion


From: Liu Hui
Subject: bug#68559: [PATCH] Improve Python shell completion
Date: Wed, 6 Mar 2024 18:14:00 +0800

On Wed, Feb 28, 2024 at 10:50 PM Basil L. Contovounesios
<basil@contovou.net> wrote:
>
> Liu Hui [2024-02-26 19:06 +0800] wrote:
>
> > +(add-hook 'python-shell-first-prompt-hook
> > +          'python-shell-readline-detect -90)
>
> This depth currently prepends the function to the hook, but in Emacs 24
> it instead appends to the hook.  Is that a problem?

Thanks for pointing it out!  It is a problem because
python-shell-readline-detect is expected to be executed before
python-shell-completion-native-turn-on-maybe-with-msg, i.e. another
function in the hook.  I have updated the patch.

> > +     (skip-when (null python-shell-readline-completer-delims))
>
> skip-unless here and below?

Done.

Attachment: 0001-Detect-the-readline-support-for-Python-shell-complet.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]