Re: wget | Draft: Initial test for dynamic buffer size for downloads (!32)

[@rockdaboot]

Tim Rühsen commented on a discussion on src/retr.c: 
https://gitlab.com/gnuwget/wget/-/merge_requests/32#note_972776585

>    int ret = 0;
>  #undef max
>  #define max(a,b) ((a) > (b) ? (a) : (b))
> -  int dlbufsize = max (BUFSIZ, 8 * 1024);
> -  char *dlbuf = xmalloc (dlbufsize);
> +  int dlbufsize = max (BUFSIZ, 16 * 1024 * 1024);

We should possibly cap it 1 or 2 MB. Because I normally see just 65464 bytes 
being read - except when the CPU is busy for some milliseconds with something 
else. So while the buffer often goes up to 2 or 4 MB because of a single event, 
the read() comes back with ~65k of data.

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget/-/merge_requests/32#note_972776585
You're receiving this email because of your account on gitlab.com.