wget-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: wget | Draft: Initial test for dynamic buffer size for downloads (!3


From: @rockdaboot
Subject: Re: wget | Draft: Initial test for dynamic buffer size for downloads (!32)
Date: Sat, 04 Jun 2022 12:31:54 +0000



Tim Rühsen started a new discussion on src/retr.c: 
https://gitlab.com/gnuwget/wget/-/merge_requests/32#note_971478761

>    int ret = 0;
>  #undef max
>  #define max(a,b) ((a) > (b) ? (a) : (b))
> -  int dlbufsize = max (BUFSIZ, 8 * 1024);
> -  char *dlbuf = xmalloc (dlbufsize);
> +  int dlbufsize = max (BUFSIZ, 16 * 1024 * 1024);

Why use max() here, BUFSIZ is normally quite small. If I interpret this 
correctly, `dlbufsize` now is the max buffer size ?

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget/-/merge_requests/32#note_971478761
You're receiving this email because of your account on gitlab.com.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]