[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: wget2 | Background support for Windows (#457)

From: Darshit Shah
Subject: Re: wget2 | Background support for Windows (#457)
Date: Fri, 24 Jan 2020 10:55:24 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

About making a change in libtest, I don't think that is required either.

In the actual test, after making the call to begin the test, run an infinite loop calling `stat(filename)` until it has the expected size. We know exactly what the size of the file should be

On 24/01/2020 10:17, Tim Rühsen via Public discussion list for GNU Wget development wrote:

Tim Rühsen commented on a discussion: 

You are the expert with Windows background processes ;-)

1. You need a change in libtest to wait for the child process to finish before 
you test the expected result.
2. You have to test that the downloads were *really* performed by the child and 
not the parent process.

Not sure if `wait()` works for processes that forked after `system()` or 

If it doesn't, you have to find out the child process ID and `waitpid()` for it.

Regarding 2.: You could write the PID of the child into the debug log, so you 
can find it there and compare with the above child PID.

Not sure how this is done on Windows. Just don't put too much work into it and 
leave the test away if you feel uncomfortable with it. IMO, there are issues 
that deserve attention much more.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]