wget-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: wget2 | Background support for Windows (#457)


From: Tim Rühsen
Subject: Re: wget2 | Background support for Windows (#457)
Date: Fri, 24 Jan 2020 09:17:49 +0000



Tim Rühsen commented on a discussion: 
https://gitlab.com/gnuwget/wget2/issues/457#note_276351647

You are the expert with Windows background processes ;-)

1. You need a change in libtest to wait for the child process to finish before 
you test the expected result.
2. You have to test that the downloads were *really* performed by the child and 
not the parent process.

Not sure if `wait()` works for processes that forked after `system()` or 
`popen()`.

If it doesn't, you have to find out the child process ID and `waitpid()` for it.

Regarding 2.: You could write the PID of the child into the debug log, so you 
can find it there and compare with the above child PID.

Not sure how this is done on Windows. Just don't put too much work into it and 
leave the test away if you feel uncomfortable with it. IMO, there are issues 
that deserve attention much more.

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/issues/457#note_276351647
You're receiving this email because of your account on gitlab.com.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]