[PATCH 2/3] move loading of modules out of the AddModule call back

[Andrei Kholodnyi]

On Fri, Nov 19, 2010 at 2:43 PM,  <Andrei.Kholodnyi at gmail.com> wrote:
>> Hi Andrei and Trevor,
>> As it stands right now, the task of loading modules is intertwined with
>> the task of parsing the configuration file. ?Parsing has side-effects.
>> I haven't looked too closely at this patch, but if I understand it
>> correctly, the parser no longer loads modules. ?To me, this seems like a
>> clean separation of the two tasks.
>>
>> Thoughts?
>
> For me the proper approach would be:
> - configuration.c is responsible for nothing, but reading AddModules strings
> from conf and putting it in array of strings.
> - speechd after reading conf, retrieves this array of strings <module1,
> module2..>, parameter ModuleAutodetection
> and implements whatever discovery/loading algorithm it wants.


I have resubmitted Trevor's patches with my proposed modifications for review.