Re: [PATCH 1/2] build-sys: fix crlf-ending C code

[Thomas Huth]

On 09/01/2023 12.21, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> On msys2, the shader-to-C script produces bad C:
> ./ui/shader/texture-blit-vert.h:2:5: error: missing terminating " character 
> [-Werror]
>
> Fix it by changing the line ending from crlf to lf, and convert the
> script to Python (qemu build seems perl-free after that).

If the build process does not depend on Perl anymore, would it make sense to 
also add a patch that removes perl from most of the containers (the ones 
that don't use check_patch.pl etc.)? ... that way we would make sure that 
the dependency does not creep in again later...

> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>   meson.build              |  2 +-
>   scripts/shaderinclude.pl | 16 ----------------
>   scripts/shaderinclude.py | 22 ++++++++++++++++++++++
>   3 files changed, 23 insertions(+), 17 deletions(-)
>   delete mode 100644 scripts/shaderinclude.pl
>   create mode 100755 scripts/shaderinclude.py

Acked-by: Thomas Huth <thuth@redhat.com>