[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/3] target: Rename headers using .def extension to .h.inc
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 0/3] target: Rename headers using .def extension to .h.inc |
Date: |
Thu, 27 Oct 2022 16:39:18 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> We use the .h.inc extension to include C headers. To be consistent
> with the rest of the codebase, rename the C headers using the .def
> extension.
>
> IDE/tools using our .editorconfig / .gitattributes will leverage
> this consistency.
>
> Philippe Mathieu-Daudé (3):
> target/m68k: Rename qregs.def -> qregs.h.inc
> target/s390x: Rename insn-data/format.def -> insn-data/format.h.inc
> target/tricore: Rename csfr.def -> csfr.h.inc
>
> target/m68k/{qregs.def => qregs.h.inc} | 0
> target/m68k/translate.c | 4 ++--
> target/s390x/tcg/{insn-data.def => insn-data.h.inc} | 2 +-
> .../s390x/tcg/{insn-format.def => insn-format.h.inc} | 0
> target/s390x/tcg/translate.c | 10 +++++-----
> target/tricore/{csfr.def => csfr.h.inc} | 0
> target/tricore/translate.c | 4 ++--
> 7 files changed, 10 insertions(+), 10 deletions(-)
> rename target/m68k/{qregs.def => qregs.h.inc} (100%)
> rename target/s390x/tcg/{insn-data.def => insn-data.h.inc} (99%)
> rename target/s390x/tcg/{insn-format.def => insn-format.h.inc} (100%)
> rename target/tricore/{csfr.def => csfr.h.inc} (100%)
I wonder why we use any of .def, .h.inc, .inc.h, .c.inc, .inc.c. Why
not .h and call it a day? No need to configure each and every editor to
tread these as C code.