Re: [PATCH 8/9] target/s390x: Use Int128 for returning float128

[Richard Henderson]

On 10/27/22 21:18, Ilya Leoshkevich wrote:
> On Fri, Oct 21, 2022 at 05:30:05PM +1000, Richard Henderson wrote:
> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> > ---
> >   target/s390x/helper.h          | 22 +++++++--------
> >   target/s390x/tcg/fpu_helper.c  | 29 ++++++++++----------
> >   target/s390x/tcg/translate.c   | 49 +++++++++++++++++++---------------
> >   target/s390x/tcg/insn-data.def | 20 +++++++-------
> >   4 files changed, 63 insertions(+), 57 deletions(-)
>
> > @@ -2032,7 +2031,7 @@ static DisasJumpType op_cxlgb(DisasContext *s, DisasOps 
> > *o)
> >       if (!m34) {
> >           return DISAS_NORETURN;
> >       }
> > -    gen_helper_cxlgb(o->out, cpu_env, o->in2, m34);
> > +    gen_helper_cxlgb(o->out_128, cpu_env, o->in2, m34);
> >       tcg_temp_free_i32(m34);
> >       return_low128(o->out2);
> >       return DISAS_NEXT;
>
> Do we still need return_low128() here?
>
> >   static DisasJumpType op_lxeb(DisasContext *s, DisasOps *o)
> >   {
> > -    gen_helper_lxeb(o->out, cpu_env, o->in2);
> > +    gen_helper_lxeb(o->out_128, cpu_env, o->in2);
> >       return_low128(o->out2);
> >       return DISAS_NEXT;
> >   }
>
> Same question.

Nope, that should have gone away.  Oops.


r~