[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/3] target: Rename headers using .def extension to .h.inc
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 0/3] target: Rename headers using .def extension to .h.inc |
Date: |
Thu, 27 Oct 2022 19:17:24 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Peter Maydell <peter.maydell@linaro.org> writes:
> On Thu, 27 Oct 2022 at 15:40, Markus Armbruster <armbru@redhat.com> wrote:
>> I wonder why we use any of .def, .h.inc, .inc.h, .c.inc, .inc.c. Why
>> not .h and call it a day? No need to configure each and every editor to
>> tread these as C code.
>
> It says "this isn't actually a header in the usual sense". That's
> useful for automated scripted checks (eg we don't want
> scripts/clean-header-guards.pl to add the standard #include header
> guards to this sort of file) and for humans (if you see one of these
> files included as part of the normal #include block at the top of
> a .c file that's probably a mistake; if you see it being used then
> you know there's likely multiple-inclusion shenanigans going on.)
scripts/clean-header-guards.pl needs exclude patterns anyway.
Comments would likely work better for humans than obscure naming
conventions.
Make them stylized, and they work for scripts, too.
- [PATCH 0/3] target: Rename headers using .def extension to .h.inc, Philippe Mathieu-Daudé, 2022/10/25
- [PATCH 1/3] target/m68k: Rename qregs.def -> qregs.h.inc, Philippe Mathieu-Daudé, 2022/10/25
- [PATCH 2/3] target/s390x: Rename insn-data/format.def -> insn-data/format.h.inc, Philippe Mathieu-Daudé, 2022/10/25
- [PATCH 3/3] target/tricore: Rename csfr.def -> csfr.h.inc, Philippe Mathieu-Daudé, 2022/10/25
- Re: [PATCH 0/3] target: Rename headers using .def extension to .h.inc, Alex Bennée, 2022/10/26
- Re: [PATCH 0/3] target: Rename headers using .def extension to .h.inc, Markus Armbruster, 2022/10/27