[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 16/26] target/s390x: Disable conditional branch-to-next for PER
From: |
Richard Henderson |
Subject: |
[PATCH 16/26] target/s390x: Disable conditional branch-to-next for PER |
Date: |
Wed, 5 Oct 2022 20:44:11 -0700 |
For PER, we require a conditional call to helper_per_branch
for the conditional branch. Fold the remaining optimization
into a call to helper_goto_direct, which will take care of
the remaining gbea adjustment.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/s390x/tcg/translate.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c
index cd311b4b2a..fc6b04e23e 100644
--- a/target/s390x/tcg/translate.c
+++ b/target/s390x/tcg/translate.c
@@ -1203,13 +1203,12 @@ static DisasJumpType help_branch(DisasContext *s,
DisasCompare *c,
goto egress;
}
if (is_imm) {
- if (disp == s->ilen) {
- /* Branch to next. */
- per_branch(s, true);
- ret = DISAS_NEXT;
- goto egress;
- }
- if (c->cond == TCG_COND_ALWAYS) {
+ /*
+ * Do not optimize a conditional branch if PER enabled, because we
+ * still need a conditional call to helper_per_branch.
+ */
+ if (c->cond == TCG_COND_ALWAYS
+ || (disp == s->ilen && !per_enabled(s))) {
ret = help_goto_direct(s, disp);
goto egress;
}
--
2.34.1
- [PATCH 09/26] target/s390x: Use gen_psw_addr_disp in save_link_info, (continued)
- [PATCH 09/26] target/s390x: Use gen_psw_addr_disp in save_link_info, Richard Henderson, 2022/10/05
- [PATCH 23/26] tcg: Pass TCGTempKind to tcg_temp_new_internal, Richard Henderson, 2022/10/05
- [PATCH 25/26] tcg: Introduce tcg_temp_is_normal_*, Richard Henderson, 2022/10/05
- [PATCH 05/26] target/s390x: Change help_goto_direct to work on displacements, Richard Henderson, 2022/10/05
- [PATCH 18/26] target/s390x: Split per_branch, Richard Henderson, 2022/10/05
- [PATCH 10/26] target/s390x: Use gen_psw_addr_disp in op_sam, Richard Henderson, 2022/10/05
- [PATCH 11/26] target/s390x: Use ilen instead in branches, Richard Henderson, 2022/10/05
- [PATCH 12/26] target/s390x: Move masking of psw.addr to cpu_get_tb_cpu_state, Richard Henderson, 2022/10/05
- [PATCH 14/26] target/s390x: Don't set gbea for user-only, Richard Henderson, 2022/10/05
- [PATCH 21/26] target/s390x: Remove PER check from use_goto_tb, Richard Henderson, 2022/10/05
- [PATCH 16/26] target/s390x: Disable conditional branch-to-next for PER,
Richard Henderson <=
- [PATCH 26/26] target/s390x: Enable TARGET_TB_PCREL, Richard Henderson, 2022/10/05
- [PATCH 13/26] target/s390x: Add disp argument to update_psw_addr, Richard Henderson, 2022/10/05
- [PATCH 15/26] target/s390x: Introduce per_enabled, Richard Henderson, 2022/10/05
- [PATCH 19/26] target/s390x: Simplify help_branch, Richard Henderson, 2022/10/05
- [PATCH 24/26] tcg: Introduce tcg_temp_ebb_new_*, Richard Henderson, 2022/10/05
- Re: [PATCH 00/26] target/s390x: pc-relative translation blocks, Richard Henderson, 2022/10/24