[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 21/26] target/s390x: Remove PER check from use_goto_tb
From: |
Richard Henderson |
Subject: |
[PATCH 21/26] target/s390x: Remove PER check from use_goto_tb |
Date: |
Wed, 5 Oct 2022 20:44:16 -0700 |
While it is common for the PC update to happen in the
shadow of a goto_tb, it is not required to be there.
By moving it before the goto_tb, we can also place the
call to helper_per_branch there, and then afterward
chain to the next tb.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/s390x/tcg/translate.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c
index a2315ac73e..e6c7c2a6ae 100644
--- a/target/s390x/tcg/translate.c
+++ b/target/s390x/tcg/translate.c
@@ -654,9 +654,6 @@ static void gen_op_calc_cc(DisasContext *s)
static bool use_goto_tb(DisasContext *s, uint64_t dest)
{
- if (per_enabled(s)) {
- return false;
- }
return translator_use_goto_tb(&s->base, dest);
}
@@ -1157,15 +1154,16 @@ static DisasJumpType help_goto_direct(DisasContext *s,
int64_t disp)
per_branch_disp(s, disp);
return DISAS_NEXT;
}
+
+ update_psw_addr_disp(s, disp);
+ per_branch_dest(s, psw_addr);
+
if (use_goto_tb(s, s->base.pc_next + disp)) {
update_cc_op(s);
tcg_gen_goto_tb(0);
- update_psw_addr_disp(s, disp);
tcg_gen_exit_tb(s->base.tb, 0);
return DISAS_NORETURN;
} else {
- update_psw_addr_disp(s, disp);
- per_branch_dest(s, psw_addr);
return DISAS_PC_UPDATED;
}
}
--
2.34.1
- [PATCH 20/26] target/s390x: Split per_breaking_event from per_branch_*, (continued)
- [PATCH 20/26] target/s390x: Split per_breaking_event from per_branch_*, Richard Henderson, 2022/10/05
- [PATCH 09/26] target/s390x: Use gen_psw_addr_disp in save_link_info, Richard Henderson, 2022/10/05
- [PATCH 23/26] tcg: Pass TCGTempKind to tcg_temp_new_internal, Richard Henderson, 2022/10/05
- [PATCH 25/26] tcg: Introduce tcg_temp_is_normal_*, Richard Henderson, 2022/10/05
- [PATCH 05/26] target/s390x: Change help_goto_direct to work on displacements, Richard Henderson, 2022/10/05
- [PATCH 18/26] target/s390x: Split per_branch, Richard Henderson, 2022/10/05
- [PATCH 10/26] target/s390x: Use gen_psw_addr_disp in op_sam, Richard Henderson, 2022/10/05
- [PATCH 11/26] target/s390x: Use ilen instead in branches, Richard Henderson, 2022/10/05
- [PATCH 12/26] target/s390x: Move masking of psw.addr to cpu_get_tb_cpu_state, Richard Henderson, 2022/10/05
- [PATCH 14/26] target/s390x: Don't set gbea for user-only, Richard Henderson, 2022/10/05
- [PATCH 21/26] target/s390x: Remove PER check from use_goto_tb,
Richard Henderson <=
- [PATCH 16/26] target/s390x: Disable conditional branch-to-next for PER, Richard Henderson, 2022/10/05
- [PATCH 26/26] target/s390x: Enable TARGET_TB_PCREL, Richard Henderson, 2022/10/05
- [PATCH 13/26] target/s390x: Add disp argument to update_psw_addr, Richard Henderson, 2022/10/05
- [PATCH 15/26] target/s390x: Introduce per_enabled, Richard Henderson, 2022/10/05
- [PATCH 19/26] target/s390x: Simplify help_branch, Richard Henderson, 2022/10/05
- [PATCH 24/26] tcg: Introduce tcg_temp_ebb_new_*, Richard Henderson, 2022/10/05
- Re: [PATCH 00/26] target/s390x: pc-relative translation blocks, Richard Henderson, 2022/10/24