Re: [PATCH v2 09/15] target/ppc: Move ADDI, ADDIS to decodetree, implement PADDI

[Richard Henderson]

On 4/28/21 7:10 AM, Matheus K. Ferst wrote:
> In our first attempt, we did some efforts to keep prefixed instructions type 
> 0b10 and 0b11 under the same implementation as their word-size counterpart, 
> i.e. trans_ADDI and trans_PADDI had the same signature and just forwarded their 
> arguments to a third method that does the real work. Is this kind of approach 
> desirable? We initially achieved this by using const_elt to set r=0 for addi, 
> which is not particularly nice, but we can look for other solutions.

Yes, I could have tried harder to share the implementation here.  And in 
retrospect, using a &PLS_D argument set for the non-prefixed integer load/store 
insns would have been fairly easy, and reduce 30 lines of unnecessary duplication.

For the MMIRR prefixed instructions, that pain of duplication would be a lot 
higher.


r~