Re: [Qemu-ppc] [PATCH 7/8] target/ppc: introduce vsrh

qemu-ppc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH 7/8] target/ppc: introduce vsrh_offset() function

From:	Richard Henderson
Subject:	Re: [Qemu-ppc] [PATCH 7/8] target/ppc: introduce vsrh_offset() function
Date:	Sun, 3 Mar 2019 15:33:31 -0800
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

On 3/3/19 9:23 AM, Mark Cave-Ayland wrote:
> -static inline int fpr_offset(int i)
> +static inline int vsrh_offset(int i)

I don't agree with this.  The original is clearer for its uses.


r~

[Prev in Thread]

Current Thread

[Next in Thread]

[Qemu-ppc] [PATCH 8/8] target/ppc: simplify get_cpu_vsrh() and get_cpu_vsrl() functions, (continued)
- [Qemu-ppc] [PATCH 8/8] target/ppc: simplify get_cpu_vsrh() and get_cpu_vsrl() functions, Mark Cave-Ayland, 2019/03/03
  - Re: [Qemu-ppc] [PATCH 8/8] target/ppc: simplify get_cpu_vsrh() and get_cpu_vsrl() functions, Richard Henderson, 2019/03/03
    - Re: [Qemu-ppc] [Qemu-devel] [PATCH 8/8] target/ppc: simplify get_cpu_vsrh() and get_cpu_vsrl() functions, Mark Cave-Ayland, 2019/03/05
    - Re: [Qemu-ppc] [Qemu-devel] [PATCH 8/8] target/ppc: simplify get_cpu_vsrh() and get_cpu_vsrl() functions, Mark Cave-Ayland, 2019/03/06
    - Re: [Qemu-ppc] [Qemu-devel] [PATCH 8/8] target/ppc: simplify get_cpu_vsrh() and get_cpu_vsrl() functions, Richard Henderson, 2019/03/06
- [Qemu-ppc] [PATCH 5/8] target/ppc: introduce avr_offset() function, Mark Cave-Ayland, 2019/03/03
  - Re: [Qemu-ppc] [PATCH 5/8] target/ppc: introduce avr_offset() function, Richard Henderson, 2019/03/03
    - Re: [Qemu-ppc] [Qemu-devel] [PATCH 5/8] target/ppc: introduce avr_offset() function, Mark Cave-Ayland, 2019/03/05
    - Re: [Qemu-ppc] [Qemu-devel] [PATCH 5/8] target/ppc: introduce avr_offset() function, Richard Henderson, 2019/03/05
- [Qemu-ppc] [PATCH 7/8] target/ppc: introduce vsrh_offset() function, Mark Cave-Ayland, 2019/03/03
  - Re: [Qemu-ppc] [PATCH 7/8] target/ppc: introduce vsrh_offset() function, Richard Henderson <=
    - Re: [Qemu-ppc] [Qemu-devel] [PATCH 7/8] target/ppc: introduce vsrh_offset() function, Mark Cave-Ayland, 2019/03/05
- [Qemu-ppc] [PATCH 2/8] target/ppc: introduce single vsrl_offset() function, Mark Cave-Ayland, 2019/03/03
  - Re: [Qemu-ppc] [PATCH 2/8] target/ppc: introduce single vsrl_offset() function, Richard Henderson, 2019/03/03
  - Re: [Qemu-ppc] [PATCH 2/8] target/ppc: introduce single vsrl_offset() function, David Gibson, 2019/03/04
- [Qemu-ppc] [PATCH 4/8] target/ppc: introduce avrh_offset() and avrl_offset() functions, Mark Cave-Ayland, 2019/03/03
  - Re: [Qemu-ppc] [PATCH 4/8] target/ppc: introduce avrh_offset() and avrl_offset() functions, Richard Henderson, 2019/03/03
    - Re: [Qemu-ppc] [Qemu-devel] [PATCH 4/8] target/ppc: introduce avrh_offset() and avrl_offset() functions, Mark Cave-Ayland, 2019/03/05
    - Re: [Qemu-ppc] [Qemu-devel] [PATCH 4/8] target/ppc: introduce avrh_offset() and avrl_offset() functions, Richard Henderson, 2019/03/05
- [Qemu-ppc] [PATCH 6/8] target/ppc: switch fpr/vsrl registers so all VSX registers are in host endian order, Mark Cave-Ayland, 2019/03/03
  - Re: [Qemu-ppc] [PATCH 6/8] target/ppc: switch fpr/vsrl registers so all VSX registers are in host endian order, Richard Henderson, 2019/03/03

Prev by Date: Re: [Qemu-ppc] [PATCH 6/8] target/ppc: switch fpr/vsrl registers so all VSX registers are in host endian order
Next by Date: Re: [Qemu-ppc] [PATCH 8/8] target/ppc: simplify get_cpu_vsrh() and get_cpu_vsrl() functions
Previous by thread: [Qemu-ppc] [PATCH 7/8] target/ppc: introduce vsrh_offset() function
Next by thread: Re: [Qemu-ppc] [Qemu-devel] [PATCH 7/8] target/ppc: introduce vsrh_offset() function
Index(es):
- Date
- Thread