|
From: | Mark Cave-Ayland |
Subject: | Re: [Qemu-ppc] [PATCH 2/2] PPC: Fix TLB invalidation bug within the PPC interrupt handler. |
Date: | Fri, 23 Mar 2012 13:53:22 +0000 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20120207 Icedove/3.0.11 |
On 23/03/12 02:20, David Gibson wrote:
I wonder why this is done again at the end of the function for booke (without regard to MSR bits). It seems like the above flush should handle booke as well as classic -- though the comment should be "changed/deactivated" rather than "disactivated", since on booke those bits just switch from one translation to another.Right, which means I don't think this test will work as is for BookE. There, we'd need to check for any change in the IS/DS bits instead of just testing presence of IR/DR bits.
Are these still MSR bits? I don't see any MSR_IS/MSR_DS defines in target-ppc/cpu.h?
ATB, Mark.
[Prev in Thread] | Current Thread | [Next in Thread] |