Re: [Qemu-ppc] [PATCH 2/2] PPC: Fix TLB invalidation bug within the PPC interrupt handler.

[Mark Cave-Ayland]

On 22/03/12 20:37, Scott Wood wrote:

> I wonder why this is done again at the end of the function for booke
> (without regard to MSR bits).  It seems like the above flush should
> handle booke as well as classic -- though the comment should be
> "changed/deactivated" rather than "disactivated", since on booke those
> bits just switch from one translation to another.

Hmmm good spot. I'm afraid I don't know enough about PPC to know why 
this is the case, but if people are primarily testing BookE then it 
could help explain why the tlb_flush() bug hasn't been detected before now.

> BTW, PPC patches should be sent to both qemu-devel@ and qemu-ppc@, not
> just the latter.

Sure. I'm a little confused as to the differentiation between the two 
lists at the moment, as it seems everyone is on both lists? Is qemu-ppc 
meant more for discussion rather than patches?


ATB,

Mark.