Re: [Qemu-discuss] Qemu-COLO bug report

[wenzt]

Thank you for quick response !

About lose network connection, I give the wrong parameters in qemu cmdline
for SVM, sorry.

About : address@hidden:colo_compare_main : secondary: unsupported.
I got between checkpoint:
address@hidden:colo_send_message Send 'vmstate-send' message
address@hidden:colo_send_message Send 'vmstate-size' message
address@hidden:colo_receive_message Receive 'vmstate-received'
message
address@hidden:colo_compare_main : secondary: unsupported packet in
<
address@hidden:colo_receive_message Receive 'vmstate-loaded'
message
{"timestamp": {"seconds": 1555071933, "microseconds": 805979}, "event":
"RESUME"}
address@hidden:colo_vm_state_change Change 'stop' => 'run'

I use tcpdump  -s 0 port 9004 -w dump.pcap,  9004 is secondary_in port on
colo-compare object.
I find out that data in pri_rs.buf  same as DATA section in ETH packet
rather than HEAD section(what we expected).

Did you get the same issue ?

Regards,
Zhengtao

> Moving the assert after the mutex lock does indeed fix this Bug for me

> Regards,
> Lukas Straub


diff --git a/net/colo-compare.c b/net/colo-compare.c index
bf10526..fcb4911 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -813,9 +813,8 @@ static void colo_compare_handle_event(void *opaque)
         break;
     }

-    assert(event_unhandled_count > 0);
-
     qemu_mutex_lock(&event_mtx);
+    assert(event_unhandled_count > 0);
     event_unhandled_count--;
     qemu_cond_broadcast(&event_complete_cond);
     qemu_mutex_unlock(&event_mtx);