Re: [Qemu-discuss] Qemu-COLO bug report

[Lukas Straub]

Moving the assert after the mutex lock does indeed fix this Bug for me

Regards,
Lukas Straub


diff --git a/net/colo-compare.c b/net/colo-compare.c index bf10526..fcb4911 
100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -813,9 +813,8 @@ static void colo_compare_handle_event(void *opaque)
         break;
     }

-    assert(event_unhandled_count > 0);
-
     qemu_mutex_lock(&event_mtx);
+    assert(event_unhandled_count > 0);
     event_unhandled_count--;
     qemu_cond_broadcast(&event_complete_cond);
     qemu_mutex_unlock(&event_mtx);