[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 1/8] hw/arm/exynos4210: Replace magic 32 by proper 'GIC_INTERNAL'
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 1/8] hw/arm/exynos4210: Replace magic 32 by proper 'GIC_INTERNAL' definition |
Date: |
Thu, 30 Jan 2025 19:24:34 +0100 |
The 32 IRQ lines skipped are the GIC internal ones.
Use the GIC_INTERNAL definition for clarity.
No logical change.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/arm/exynos4210.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/arm/exynos4210.c b/hw/arm/exynos4210.c
index dd0edc81d5c..99b05a175d6 100644
--- a/hw/arm/exynos4210.c
+++ b/hw/arm/exynos4210.c
@@ -393,8 +393,9 @@ static void exynos4210_init_board_irqs(Exynos4210State *s)
}
}
if (irq_id) {
+ irq_id -= GIC_INTERNAL;
qdev_connect_gpio_out(splitter, splitin,
- qdev_get_gpio_in(extgicdev, irq_id - 32));
+ qdev_get_gpio_in(extgicdev, irq_id));
}
}
for (; n < EXYNOS4210_MAX_INT_COMBINER_IN_IRQ; n++) {
@@ -413,6 +414,7 @@ static void exynos4210_init_board_irqs(Exynos4210State *s)
}
if (irq_id) {
+ irq_id -= GIC_INTERNAL;
assert(splitcount < EXYNOS4210_NUM_SPLITTERS);
splitter = DEVICE(&s->splitter[splitcount]);
qdev_prop_set_uint16(splitter, "num-lines", 2);
@@ -421,7 +423,7 @@ static void exynos4210_init_board_irqs(Exynos4210State *s)
s->irq_table[n] = qdev_get_gpio_in(splitter, 0);
qdev_connect_gpio_out(splitter, 0, qdev_get_gpio_in(intcdev, n));
qdev_connect_gpio_out(splitter, 1,
- qdev_get_gpio_in(extgicdev, irq_id - 32));
+ qdev_get_gpio_in(extgicdev, irq_id));
} else {
s->irq_table[n] = qdev_get_gpio_in(intcdev, n);
}
--
2.47.1
- [PATCH 0/8] hw/arm: Explicit number of GIC external IRQs for Cortex A9/A15 MPCore, Philippe Mathieu-Daudé, 2025/01/30
- [PATCH 1/8] hw/arm/exynos4210: Replace magic 32 by proper 'GIC_INTERNAL' definition,
Philippe Mathieu-Daudé <=
- [PATCH 2/8] hw/arm/exynos4210: Explicit number of GIC external IRQs, Philippe Mathieu-Daudé, 2025/01/30
- [PATCH 3/8] hw/arm/realview: Explicit number of GIC external IRQs, Philippe Mathieu-Daudé, 2025/01/30
- [PATCH 4/8] hw/arm/xilinx_zynq: Replace IRQ_OFFSET -> GIC_INTERNAL, Philippe Mathieu-Daudé, 2025/01/30
- [PATCH 5/8] hw/arm/xilinx_zynq: Explicit number of GIC external IRQs, Philippe Mathieu-Daudé, 2025/01/30
- [PATCH 6/8] hw/arm/vexpress: Explicit number of GIC external IRQs, Philippe Mathieu-Daudé, 2025/01/30
- [PATCH 7/8] hw/arm/highbank: Explicit number of GIC external IRQs, Philippe Mathieu-Daudé, 2025/01/30
- [PATCH 8/8] hw/cpu/arm_mpcore: Remove default values for GIC external IRQs, Philippe Mathieu-Daudé, 2025/01/30