qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 19/76] fpu: Rename float_flag_input_denormal to float_flag_in


From: Richard Henderson
Subject: Re: [PATCH 19/76] fpu: Rename float_flag_input_denormal to float_flag_input_denormal_flushed
Date: Sat, 25 Jan 2025 07:25:53 -0800
User-agent: Mozilla Thunderbird

On 1/24/25 08:27, Peter Maydell wrote:
Our float_flag_input_denormal exception flag is set when the fpu code
flushes an input denormal to zero.  This is what many guest
architectures (eg classic Arm behaviour) require, but it is not the
only donarmal-related reason we might want to set an exception flag.
The x86 behaviour (which we do not currently model correctly) wants
to see an exception flag when a denormal input is*not* flushed to
zero and is actually used in an arithmetic operation. Arm's FEAT_AFP
also wants these semantics.

Rename float_flag_input_denormal to float_flag_input_denormal_flushed
to make it clearer when it is set and to allow us to add a new
float_flag_input_denormal_used next to it for the x86/FEAT_AFP
semantics.

Commit created with
  for f in `git grep -l float_flag_input_denormal`; do sed -i -e 
's/float_flag_input_denormal/float_flag_input_denormal_flushed/' $f; done

and manual editing of softfloat-types.h and softfloat.c to clean
up the indentation afterwards and to fix a comment which wasn't
using the full name of the flag.

Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
---
  include/fpu/softfloat-types.h |  5 +++--
  fpu/softfloat.c               |  4 ++--
  target/arm/tcg/sve_helper.c   |  6 +++---
  target/arm/vfp_helper.c       | 10 +++++-----
  target/i386/tcg/fpu_helper.c  |  6 +++---
  target/mips/tcg/msa_helper.c  |  2 +-
  target/rx/op_helper.c         |  2 +-
  fpu/softfloat-parts.c.inc     |  2 +-
  8 files changed, 19 insertions(+), 18 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]