[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 06/55] hw/qdev: Pass bus argument to qdev_hotplug_allowed()
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL v2 06/55] hw/qdev: Pass bus argument to qdev_hotplug_allowed() |
Date: |
Mon, 13 Jan 2025 18:35:58 +0100 |
From: Akihiko Odaki <akihiko.odaki@daynix.com>
In preparation of checking the parent bus is hot(un)pluggable
in a few commits, pass a 'bus' argument to qdev_hotplug_allowed().
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
[PMD: Split from bigger patch, part 1/6]
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <20250110091908.64454-2-philmd@linaro.org>
---
include/hw/qdev-core.h | 2 +-
hw/core/qdev-hotplug.c | 2 +-
system/qdev-monitor.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h
index 89575e74e27..930b00fb09a 100644
--- a/include/hw/qdev-core.h
+++ b/include/hw/qdev-core.h
@@ -540,7 +540,7 @@ void qdev_set_legacy_instance_id(DeviceState *dev, int
alias_id,
int required_for_version);
HotplugHandler *qdev_get_bus_hotplug_handler(DeviceState *dev);
HotplugHandler *qdev_get_machine_hotplug_handler(DeviceState *dev);
-bool qdev_hotplug_allowed(DeviceState *dev, Error **errp);
+bool qdev_hotplug_allowed(DeviceState *dev, BusState *bus, Error **errp);
/**
* qdev_get_hotplug_handler() - Get handler responsible for device wiring
diff --git a/hw/core/qdev-hotplug.c b/hw/core/qdev-hotplug.c
index d495d0e9c70..19fbb11a316 100644
--- a/hw/core/qdev-hotplug.c
+++ b/hw/core/qdev-hotplug.c
@@ -30,7 +30,7 @@ HotplugHandler *qdev_get_machine_hotplug_handler(DeviceState
*dev)
return NULL;
}
-bool qdev_hotplug_allowed(DeviceState *dev, Error **errp)
+bool qdev_hotplug_allowed(DeviceState *dev, BusState *bus, Error **errp)
{
MachineState *machine;
MachineClass *mc;
diff --git a/system/qdev-monitor.c b/system/qdev-monitor.c
index 23043b1e0d5..83388dc0c4a 100644
--- a/system/qdev-monitor.c
+++ b/system/qdev-monitor.c
@@ -691,7 +691,7 @@ DeviceState *qdev_device_add_from_qdict(const QDict *opts,
/* Check whether the hotplug is allowed by the machine */
if (phase_check(PHASE_MACHINE_READY)) {
- if (!qdev_hotplug_allowed(dev, errp)) {
+ if (!qdev_hotplug_allowed(dev, bus, errp)) {
goto err_del_dev;
}
--
2.47.1
- [PULL v2 00/55] Misc HW patches for 2025-01-12, Philippe Mathieu-Daudé, 2025/01/13
- [PULL v2 10/55] hw/qdev: Check qbus_is_hotpluggable in hotplug_unplug_allowed_common, Philippe Mathieu-Daudé, 2025/01/13
- [PULL v2 55/55] Add a b4 configuration file, Philippe Mathieu-Daudé, 2025/01/13
- [PULL v2 06/55] hw/qdev: Pass bus argument to qdev_hotplug_allowed(),
Philippe Mathieu-Daudé <=
- [PULL v2 09/55] hw/qdev: Check DevClass::hotpluggable in hotplug_unplug_allowed_common, Philippe Mathieu-Daudé, 2025/01/13
- [PULL v2 08/55] hw/qdev: Introduce qdev_hotplug_unplug_allowed_common(), Philippe Mathieu-Daudé, 2025/01/13
- [PULL v2 07/55] hw/qdev: Factor qdev_hotunplug_allowed() out, Philippe Mathieu-Daudé, 2025/01/13
- [PULL v2 11/55] hw/qdev: Check machine_hotplug_handler in hotplug_unplug_allowed_common, Philippe Mathieu-Daudé, 2025/01/13
- Re: [PULL v2 00/55] Misc HW patches for 2025-01-12, Stefan Hajnoczi, 2025/01/14