[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 1/6] hw/qdev: Pass bus argument to qdev_hotplug_allowed()
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v5 1/6] hw/qdev: Pass bus argument to qdev_hotplug_allowed() |
Date: |
Fri, 10 Jan 2025 10:19:03 +0100 |
From: Akihiko Odaki <akihiko.odaki@daynix.com>
In preparation of checking the parent bus is hot(un)pluggable
in a few commits, pass a 'bus' argument to qdev_hotplug_allowed().
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
include/hw/qdev-core.h | 2 +-
hw/core/qdev-hotplug.c | 2 +-
system/qdev-monitor.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h
index e6ef80b7fd0..b4a5b203aab 100644
--- a/include/hw/qdev-core.h
+++ b/include/hw/qdev-core.h
@@ -544,7 +544,7 @@ void qdev_set_legacy_instance_id(DeviceState *dev, int
alias_id,
int required_for_version);
HotplugHandler *qdev_get_bus_hotplug_handler(DeviceState *dev);
HotplugHandler *qdev_get_machine_hotplug_handler(DeviceState *dev);
-bool qdev_hotplug_allowed(DeviceState *dev, Error **errp);
+bool qdev_hotplug_allowed(DeviceState *dev, BusState *bus, Error **errp);
/**
* qdev_get_hotplug_handler() - Get handler responsible for device wiring
diff --git a/hw/core/qdev-hotplug.c b/hw/core/qdev-hotplug.c
index d495d0e9c70..19fbb11a316 100644
--- a/hw/core/qdev-hotplug.c
+++ b/hw/core/qdev-hotplug.c
@@ -30,7 +30,7 @@ HotplugHandler *qdev_get_machine_hotplug_handler(DeviceState
*dev)
return NULL;
}
-bool qdev_hotplug_allowed(DeviceState *dev, Error **errp)
+bool qdev_hotplug_allowed(DeviceState *dev, BusState *bus, Error **errp)
{
MachineState *machine;
MachineClass *mc;
diff --git a/system/qdev-monitor.c b/system/qdev-monitor.c
index c844f538025..bf1afb81886 100644
--- a/system/qdev-monitor.c
+++ b/system/qdev-monitor.c
@@ -690,7 +690,7 @@ DeviceState *qdev_device_add_from_qdict(const QDict *opts,
/* Check whether the hotplug is allowed by the machine */
if (phase_check(PHASE_MACHINE_READY)) {
- if (!qdev_hotplug_allowed(dev, errp)) {
+ if (!qdev_hotplug_allowed(dev, bus, errp)) {
goto err_del_dev;
}
--
2.47.1
- [PATCH v5 0/6] hw/core: Unify hotplug decision logic, Philippe Mathieu-Daudé, 2025/01/10
- [PATCH v5 1/6] hw/qdev: Pass bus argument to qdev_hotplug_allowed(),
Philippe Mathieu-Daudé <=
- [PATCH v5 2/6] hw/qdev: Factor qdev_hotunplug_allowed() out, Philippe Mathieu-Daudé, 2025/01/10
- [PATCH v5 3/6] hw/qdev: Introduce qdev_hotplug_unplug_allowed_common(), Philippe Mathieu-Daudé, 2025/01/10
- [PATCH v5 4/6] hw/qdev: Check DevClass::hotpluggable in hotplug_unplug_allowed_common, Philippe Mathieu-Daudé, 2025/01/10
- [PATCH v5 5/6] hw/qdev: Check qbus_is_hotpluggable in hotplug_unplug_allowed_common, Philippe Mathieu-Daudé, 2025/01/10
- [PATCH v5 6/6] hw/qdev: Check machine_hotplug_handler in hotplug_unplug_allowed_common, Philippe Mathieu-Daudé, 2025/01/10
- Re: [PATCH v5 0/6] hw/core: Unify hotplug decision logic, Philippe Mathieu-Daudé, 2025/01/10