[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 3/6] hw/qdev: Introduce qdev_hotplug_unplug_allowed_common()
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v5 3/6] hw/qdev: Introduce qdev_hotplug_unplug_allowed_common() |
Date: |
Fri, 10 Jan 2025 10:19:05 +0100 |
From: Akihiko Odaki <akihiko.odaki@daynix.com>
Introduce qdev_hotplug_unplug_allowed_common() to hold
common code between checking hot-plug/unplug is allowed.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/core/qdev-hotplug.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/hw/core/qdev-hotplug.c b/hw/core/qdev-hotplug.c
index dc35110e735..168d7964740 100644
--- a/hw/core/qdev-hotplug.c
+++ b/hw/core/qdev-hotplug.c
@@ -30,12 +30,22 @@ HotplugHandler
*qdev_get_machine_hotplug_handler(DeviceState *dev)
return NULL;
}
+static bool qdev_hotplug_unplug_allowed_common(DeviceState *dev, BusState *bus,
+ Error **errp)
+{
+ return true;
+}
+
bool qdev_hotplug_allowed(DeviceState *dev, BusState *bus, Error **errp)
{
MachineState *machine;
MachineClass *mc;
Object *m_obj = qdev_get_machine();
+ if (!qdev_hotplug_unplug_allowed_common(dev, bus, errp)) {
+ return false;
+ }
+
if (object_dynamic_cast(m_obj, TYPE_MACHINE)) {
machine = MACHINE(m_obj);
mc = MACHINE_GET_CLASS(machine);
@@ -49,7 +59,8 @@ bool qdev_hotplug_allowed(DeviceState *dev, BusState *bus,
Error **errp)
bool qdev_hotunplug_allowed(DeviceState *dev, Error **errp)
{
- return !qdev_unplug_blocked(dev, errp);
+ return !qdev_unplug_blocked(dev, errp) &&
+ qdev_hotplug_unplug_allowed_common(dev, dev->parent_bus, errp);
}
HotplugHandler *qdev_get_bus_hotplug_handler(DeviceState *dev)
--
2.47.1
- [PATCH v5 0/6] hw/core: Unify hotplug decision logic, Philippe Mathieu-Daudé, 2025/01/10
- [PATCH v5 1/6] hw/qdev: Pass bus argument to qdev_hotplug_allowed(), Philippe Mathieu-Daudé, 2025/01/10
- [PATCH v5 2/6] hw/qdev: Factor qdev_hotunplug_allowed() out, Philippe Mathieu-Daudé, 2025/01/10
- [PATCH v5 3/6] hw/qdev: Introduce qdev_hotplug_unplug_allowed_common(),
Philippe Mathieu-Daudé <=
- [PATCH v5 4/6] hw/qdev: Check DevClass::hotpluggable in hotplug_unplug_allowed_common, Philippe Mathieu-Daudé, 2025/01/10
- [PATCH v5 5/6] hw/qdev: Check qbus_is_hotpluggable in hotplug_unplug_allowed_common, Philippe Mathieu-Daudé, 2025/01/10
- [PATCH v5 6/6] hw/qdev: Check machine_hotplug_handler in hotplug_unplug_allowed_common, Philippe Mathieu-Daudé, 2025/01/10
- Re: [PATCH v5 0/6] hw/core: Unify hotplug decision logic, Philippe Mathieu-Daudé, 2025/01/10