[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 07/55] hw/qdev: Factor qdev_hotunplug_allowed() out
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL v2 07/55] hw/qdev: Factor qdev_hotunplug_allowed() out |
Date: |
Mon, 13 Jan 2025 18:35:59 +0100 |
From: Akihiko Odaki <akihiko.odaki@daynix.com>
Factor qdev_hotunplug_allowed() out of qdev_unplug().
Start checking the device is not blocked.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
[PMD: Split from bigger patch, part 2/6]
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <20250110091908.64454-3-philmd@linaro.org>
---
include/hw/qdev-core.h | 1 +
hw/core/qdev-hotplug.c | 5 +++++
system/qdev-monitor.c | 2 +-
3 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h
index 930b00fb09a..530f3da7021 100644
--- a/include/hw/qdev-core.h
+++ b/include/hw/qdev-core.h
@@ -541,6 +541,7 @@ void qdev_set_legacy_instance_id(DeviceState *dev, int
alias_id,
HotplugHandler *qdev_get_bus_hotplug_handler(DeviceState *dev);
HotplugHandler *qdev_get_machine_hotplug_handler(DeviceState *dev);
bool qdev_hotplug_allowed(DeviceState *dev, BusState *bus, Error **errp);
+bool qdev_hotunplug_allowed(DeviceState *dev, Error **errp);
/**
* qdev_get_hotplug_handler() - Get handler responsible for device wiring
diff --git a/hw/core/qdev-hotplug.c b/hw/core/qdev-hotplug.c
index 19fbb11a316..dc35110e735 100644
--- a/hw/core/qdev-hotplug.c
+++ b/hw/core/qdev-hotplug.c
@@ -47,6 +47,11 @@ bool qdev_hotplug_allowed(DeviceState *dev, BusState *bus,
Error **errp)
return true;
}
+bool qdev_hotunplug_allowed(DeviceState *dev, Error **errp)
+{
+ return !qdev_unplug_blocked(dev, errp);
+}
+
HotplugHandler *qdev_get_bus_hotplug_handler(DeviceState *dev)
{
if (dev->parent_bus) {
diff --git a/system/qdev-monitor.c b/system/qdev-monitor.c
index 83388dc0c4a..511d1aa83c2 100644
--- a/system/qdev-monitor.c
+++ b/system/qdev-monitor.c
@@ -909,7 +909,7 @@ void qdev_unplug(DeviceState *dev, Error **errp)
HotplugHandlerClass *hdc;
Error *local_err = NULL;
- if (qdev_unplug_blocked(dev, errp)) {
+ if (!qdev_hotunplug_allowed(dev, errp)) {
return;
}
--
2.47.1
- [PULL v2 00/55] Misc HW patches for 2025-01-12, Philippe Mathieu-Daudé, 2025/01/13
- [PULL v2 10/55] hw/qdev: Check qbus_is_hotpluggable in hotplug_unplug_allowed_common, Philippe Mathieu-Daudé, 2025/01/13
- [PULL v2 55/55] Add a b4 configuration file, Philippe Mathieu-Daudé, 2025/01/13
- [PULL v2 06/55] hw/qdev: Pass bus argument to qdev_hotplug_allowed(), Philippe Mathieu-Daudé, 2025/01/13
- [PULL v2 09/55] hw/qdev: Check DevClass::hotpluggable in hotplug_unplug_allowed_common, Philippe Mathieu-Daudé, 2025/01/13
- [PULL v2 08/55] hw/qdev: Introduce qdev_hotplug_unplug_allowed_common(), Philippe Mathieu-Daudé, 2025/01/13
- [PULL v2 07/55] hw/qdev: Factor qdev_hotunplug_allowed() out,
Philippe Mathieu-Daudé <=
- [PULL v2 11/55] hw/qdev: Check machine_hotplug_handler in hotplug_unplug_allowed_common, Philippe Mathieu-Daudé, 2025/01/13
- Re: [PULL v2 00/55] Misc HW patches for 2025-01-12, Stefan Hajnoczi, 2025/01/14