Re: [PATCH v4 2/2] tests/qtest/libqos: add DMA support for writing and reading fw_cfg files

[Gerd Hoffmann]

On Fri, Jan 10, 2025 at 10:53:32AM +0530, Ani Sinha wrote:
> 
> 
> > On 10 Jan 2025, at 2:00 AM, Fabiano Rosas <farosas@suse.de> wrote:
> > 
> > Ani Sinha <anisinha@redhat.com> writes:
> > 
> >> At present, the libqos/fw_cfg.c library does not support the modern DMA
> >> interface which is required to write to the fw_cfg files. It only uses the 
> >> IO
> >> interface. Implement read and write methods based on DMA. This will enable
> >> developers to write tests that writes to the fw_cfg file(s). The structure 
> >> of
> >> the code is taken from edk2 fw_cfg implementation. It has been tested by
> >> writing a qtest that writes to a fw_cfg file. This test will be part of a
> >> future patch series.
> > 
> > What's the blocker for the rest of the series?
> 
> The broker is that the consumer of this api is a new qtest which is written 
> to test a brand new feature.

A in-tree user of fw_cfg file writes is ramfb, so writing a ramfb test
would be an option ...

take care,
  Gerd