qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 2/2] tests/qtest/libqos: add DMA support for writing and r


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v4 2/2] tests/qtest/libqos: add DMA support for writing and reading fw_cfg files
Date: Fri, 10 Jan 2025 07:43:57 +0100
User-agent: Mozilla Thunderbird

On 9/1/25 21:30, Fabiano Rosas wrote:
Ani Sinha <anisinha@redhat.com> writes:

At present, the libqos/fw_cfg.c library does not support the modern DMA
interface which is required to write to the fw_cfg files. It only uses the IO
interface. Implement read and write methods based on DMA. This will enable
developers to write tests that writes to the fw_cfg file(s). The structure of
the code is taken from edk2 fw_cfg implementation. It has been tested by
writing a qtest that writes to a fw_cfg file. This test will be part of a
future patch series.

What's the blocker for the rest of the series? It would be preferable to
merge it all together, rather than this going in first without any
users.

Agreed. We could use a multiboot image, or a guest with vmcoreinfo
support. Or a dumbier test just testing this API.


Signed-off-by: Ani Sinha <anisinha@redhat.com>
---
  tests/qtest/libqos/fw_cfg.c | 138 ++++++++++++++++++++++++++++++++++++
  tests/qtest/libqos/fw_cfg.h |   6 +-
  2 files changed, 143 insertions(+), 1 deletion(-)





reply via email to

[Prev in Thread] Current Thread [Next in Thread]