Re: [PATCH v2 1/1] hw/nvme: Add OCP SMART / Health Information Extended Log Page

[Klaus Jensen]

On Nov 29 09:27, Stephen Bates wrote:
> The Open Compute Project [1] includes a Datacenter NVMe
> SSD Specification [2]. The most recent version of this specification
> (as of November 2024) is 2.6.1. This specification layers on top of
> the NVM Express specifications [3] to provide additional
> functionality. A key part of of this is the 512 Byte OCP SMART / Health
> Information Extended log page that is defined in Section 4.8.6 of the
> specification.
> 
> We add a controller argument (ocp) that toggles on/off the SMART log
> extended structure.  To accommodate different vendor specific specifications
> like OCP, we add a multiplexing function (nvme_vendor_specific_log) which
> will route to the different log functions based on arguments and log ids.
> We only return the OCP extended SMART log when the command is 0xC0 and ocp
> has been turned on in the nvme argumants.
> 
> Though we add the whole nvme SMART log extended structure, we only populate
> the physical_media_units_{read,written}, log_page_version and
> log_page_uuid.
> 
> This patch is based on work done by Joel but has been modified enough
> that he requested a co-developed-by tag rather than a signed-off-by.
> 
> [1]: https://www.opencompute.org/
> [2]: 
> https://www.opencompute.org/documents/datacenter-nvme-ssd-specification-v2-6-1-pdf
> [3]: https://nvmexpress.org/specifications/
> 
> Signed-off-by: Stephen Bates <sbates@raithlin.com>
> Co-developed-by: Joel Granados <j.granados@samsung.com>

Hi Stephen,

Reviewed-by: Klaus Jensen <k.jensen@samsung.com>

Thanks! Applied to nvme-next!

signature.asc
Description: PGP signature